From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 15/33] drm/i915: DSPARB register needs an offset on VLV Date: Thu, 24 Jan 2013 23:01:42 +0100 Message-ID: <20130124220142.GA23080@phenom.ffwll.local> References: <1359034198-19678-1-git-send-email-ville.syrjala@linux.intel.com> <1359034198-19678-16-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 92AB6E6C60 for ; Thu, 24 Jan 2013 13:59:43 -0800 (PST) Received: by mail-ee0-f42.google.com with SMTP id b47so5020695eek.29 for ; Thu, 24 Jan 2013 13:59:42 -0800 (PST) Content-Disposition: inline In-Reply-To: <1359034198-19678-16-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 24, 2013 at 03:29:40PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > Signed-off-by: Ville Syrj=E4l=E4 With Paulo's patch to no longer safe/resume DSPARB on gen4+ gone, there's no user of this left for vlv. And I wouldn't be surprised at all if the register has a completely different function now, so maybe if we ever need it we need a VLV_DSPARB or something like that. -Daniel > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_= reg.h > index c3eaa69..3ac695d 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -2744,7 +2744,7 @@ > #define PLANEA_INVALID_GTT_STATUS (1<<0) > #define DPINVGTT_STATUS_MASK 0xff > = > -#define DSPARB 0x70030 > +#define DSPARB (dev_priv->info->display_mmio_offset + 0x70030) > #define DSPARB_CSTART_MASK (0x7f << 7) > #define DSPARB_CSTART_SHIFT 7 > #define DSPARB_BSTART_MASK (0x7f) > -- = > 1.7.12.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch