From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serge Hallyn Subject: Re: [PATCH 04/11] Add backend support for suboridnate uids and gids Date: Thu, 24 Jan 2013 16:50:08 -0600 Message-ID: <20130124225008.GA3816@sergelap> References: <87d2wxshu0.fsf@xmission.com> <87liblr344.fsf@xmission.com> <20130123182206.GA4468@mail.hallyn.com> <87a9ryyzh2.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87a9ryyzh2.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: Linux Containers , Pkg-shadow-devel-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org, "Michael Kerrisk (man-pages)" , Nicolas =?iso-8859-1?Q?Fran=E7ois?= List-Id: containers.vger.kernel.org Quoting Eric W. Biederman (ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org): > In practice it doesn't matter but it looks worth fixing for the sake of > long term maintenance. I figured the users must all be ok, and in practice it would work out, but the fact remains subsequent function calls assigning to local stack can overwrite what you've returned. The rest of what I've looked over looked ok, thanks much! -serge