From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCHv2] tools lib traceevent: Handle dynamic array's element size properly
Date: Thu, 24 Jan 2013 19:58:28 -0300 [thread overview]
Message-ID: <20130124225828.GE14382@infradead.org> (raw)
In-Reply-To: <1359063185.21576.157.camel@gandalf.local.home>
Em Thu, Jan 24, 2013 at 04:33:05PM -0500, Steven Rostedt escreveu:
> On Thu, 2013-01-24 at 18:28 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jan 24, 2013 at 04:13:13PM -0500, Steven Rostedt escreveu:
> > > On Thu, 2013-01-24 at 21:46 +0100, Jiri Olsa wrote:
> > > >
> > > > +static unsigned int type_size(char *name)
> > >
> > > Sorry to nitpick, but please make that const char *name.
> >
> > Agreed, no need to resubmit, I'll fix that up.
>
> I'm sure Tom St Denis appreciates it.
>
> >
> > > The rest looks good.
> >
> > Thanks, adding your Acked-by,
>
> Sure. But I probably should test it too ;-)
ROFL
- Arnaldo
next prev parent reply other threads:[~2013-01-24 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 20:46 [PATCHv2] tools lib traceevent: Handle dynamic array's element size properly Jiri Olsa
2013-01-24 21:13 ` Steven Rostedt
2013-01-24 21:28 ` Arnaldo Carvalho de Melo
2013-01-24 21:33 ` Steven Rostedt
2013-01-24 22:58 ` Arnaldo Carvalho de Melo [this message]
2013-01-31 10:36 ` [tip:perf/core] tools lib traceevent: Handle dynamic array' s " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124225828.GE14382@infradead.org \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.