From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC Patch v6] Consolidate bool type
Date: Thu, 24 Jan 2013 17:00:05 -0800 [thread overview]
Message-ID: <20130125010005.GB3769@badger> (raw)
In-Reply-To: <1359069137-24238-1-git-send-email-yorksun@freescale.com>
On Thu, Jan 24, 2013 at 03:12:17PM -0800, York Sun wrote:
> 'bool' is defined in random places. This patch consolidates them into a
> single header file include/linux/types.h, using stdbool.h introduced in C99.
>
> All other #define, typedef and enum are removed. They are all consistent with
> true = 1, false = 0.
>
> Replace FALSE, False with false. Replace TRUE, True with true.
> Skip *.py, *.php, lib/* files.
>
> Signed-off-by: York Sun <yorksun@freescale.com>
> ---
> Change since v1:
> Move 'false' and 'true' to the common header file.
>
> Change since v2:
> Use stdbool.h
> Consolidate all TRUE, FALSE, True, False, true, false
>
> Change since v3:
> Fix boolean_t which was missed in v2.
>
> Change since v4:
> Replace FALSE, False with false. Replace TRUE, True with true.
>
> Change since v5:
> Revert changes for *.py, *.php, lib/* files.
> Revert change to type conversions.
> Revert comment-only changes. (Not sure about if we should replace the comments).
> Fix many coding style issues but left drivers/net/npe alone (way too many issues).
>
> This patch doesn't address the white space issue where TRUE/FALSE is repalced.
>
> Need help to test on all ARCHs with differnt toolchains as well as USE_PRIVATE_LIBGCC.
I think you can drop the RFC from your patch at this point.
Built on all tegra20 and tegra30 devices with USE_PRIVATE_LIBGCC.
Tested on seaboard (tegra20).
I've also submitted your patch to my build regression script which
will build all 1100+ boards against your patch and tell if there are
any build regressions. I'll let you know the results tomorrow.
-Allen
--
nvpublic
next prev parent reply other threads:[~2013-01-25 1:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 23:12 [U-Boot] [RFC Patch v6] Consolidate bool type York Sun
2013-01-25 1:00 ` Allen Martin [this message]
2013-01-30 18:37 ` York Sun
2013-01-30 19:40 ` Allen Martin
2013-01-30 19:47 ` York Sun
2013-01-30 22:53 ` Allen Martin
2013-01-30 23:09 ` York Sun
2013-01-30 23:24 ` Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125010005.GB3769@badger \
--to=amartin@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.