From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC BlueZ 0/6] LE Connection Establishment fixes
Date: Fri, 25 Jan 2013 09:12:15 +0200 [thread overview]
Message-ID: <20130125071215.GC17746@x220> (raw)
In-Reply-To: <1359083227-13122-1-git-send-email-vinicius.gomes@openbossa.org>
Hi Vinicius,
On Fri, Jan 25, 2013, Vinicius Costa Gomes wrote:
> The only problem with this aproach that I found while testing is the
> problem exposed on the message of commit 5/6: If the remote device is
> out of range during pairing any connection attempt will fail until the
> Connection Complete event comes (with an error). This is the reason
> that we put the devices in the connect list before pairing.
>
> Is this reason enough to have the device put in the connect list
> during pairing?
I don't think so. The mgmt_pair_device should have a timeout for LE
devices on the kernel side, but since this is not the case with current
kernel versions we'll need a workaround in user space. I.e. instead of
using scanning (I assume that's what putting it on the connect list will
do) you should just use a simple timeout (g_timeout_add_seconds) and
call mgmt_cancel_pair_device if it expires.
Johan
next prev parent reply other threads:[~2013-01-25 7:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 3:07 [RFC BlueZ 0/6] LE Connection Establishment fixes Vinicius Costa Gomes
2013-01-25 3:07 ` [RFC BlueZ 1/6] device: Fix invalid memory access during Find Included Vinicius Costa Gomes
2013-01-25 7:07 ` Johan Hedberg
2013-01-25 3:07 ` [RFC BlueZ 2/6] device: Fix memory leak while storing GATT capable devices Vinicius Costa Gomes
2013-01-25 7:08 ` Johan Hedberg
2013-01-25 3:07 ` [RFC BlueZ 3/6] device: Clean up device_att_connect() Vinicius Costa Gomes
2013-01-25 3:07 ` [RFC BlueZ 4/6] device: Rename device_att_connect to device_connect_le Vinicius Costa Gomes
2013-01-25 7:32 ` Johan Hedberg
2013-01-25 3:07 ` [RFC BlueZ 5/6] core: Add a way to connect to LE devices Vinicius Costa Gomes
2013-01-25 3:07 ` [RFC BlueZ 6/6] gas: Move all the code to only one file Vinicius Costa Gomes
2013-01-25 7:36 ` Johan Hedberg
2013-01-25 10:55 ` Anderson Lizardo
2013-01-25 7:12 ` Johan Hedberg [this message]
2013-01-25 9:55 ` [RFC BlueZ 0/6] LE Connection Establishment fixes Johan Hedberg
2013-01-25 11:30 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125071215.GC17746@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.