From: "Jörn Engel" <joern@logfs.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com>,
Sreekanth Reddy <Sreekanth.Reddy@lsi.com>,
support@lsi.com,
"James E.J. Bottomley" <JBottomley@parallels.com>,
DL-MPTFusionLinux@lsi.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mpt2sas: prevent double free on error path
Date: Fri, 25 Jan 2013 12:12:55 -0500 [thread overview]
Message-ID: <20130125171255.GA22141@logfs.org> (raw)
In-Reply-To: <87k3r310jr.fsf@nemi.mork.no>
On Thu, 24 January 2013 08:51:20 +0100, Bjørn Mork wrote:
>
> How about the copy of this code in drivers/scsi/mpt3sas/mpt3sas_scsih.c?
> Is that safe, or does it need fixing as well?
Well spotted, that appears to suffer from the same ailment. Will cook
up a second patch for that.
Are there any other copies of this code around?
Jörn
--
The object-oriented version of 'Spaghetti code' is, of course, 'Lasagna code'.
(Too many layers).
-- Roberto Waltman.
next prev parent reply other threads:[~2013-01-25 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 21:20 [PATCH] mpt2sas: prevent double free on error path Jörn Engel
2013-01-24 7:51 ` Bjørn Mork
2013-01-24 7:51 ` Bjørn Mork
2013-01-25 17:12 ` Jörn Engel [this message]
2013-01-25 18:00 ` [PATCH v2] mpt2sas/mpt3sas: " Jörn Engel
2013-01-25 18:00 ` Jörn Engel
2013-01-25 19:20 ` [PATCH v3] " Jörn Engel
2013-01-26 3:52 ` mpt2sas: device_blocked question spren.gm
2013-01-30 6:52 ` Reddy, Sreekanth
-- strict thread matches above, loose matches on Subject: below --
2013-05-09 20:42 [PATCH 00/14] Add blockconsole version 1.1 (try 3) Joern Engel
2013-05-09 20:42 ` [PATCH] mpt2sas: prevent double free on error path Joern Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125171255.GA22141@logfs.org \
--to=joern@logfs.org \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=JBottomley@parallels.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=Sreekanth.Reddy@lsi.com \
--cc=bjorn@mork.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=support@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.