From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Ivo Van Doorn <ivdoorn@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Xose Vazquez Perez <xose.vazquez@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
rt2x00 Users List <users@rt2x00.serialmonkey.com>
Subject: Re: [PATCH 2/4] rt2x00: remove NOTICE
Date: Sat, 26 Jan 2013 18:09:48 +0100 [thread overview]
Message-ID: <20130126170948.GA5834@localhost.localdomain> (raw)
In-Reply-To: <CAOZOX0Vj-T1WPHR692LwpSdHontVq5PJG4UJAzg7O=nYLodXOA@mail.gmail.com>
On Fri, Jan 25, 2013 at 01:28:44PM +0100, Ivo Van Doorn wrote:
> On Thu, Jan 24, 2013 at 10:00 PM, Stanislaw Gruszka <stf_xl@wp.pl> wrote:
> > We use this macro only on 3 places - remove it and replace by other
> > appropriate macros for printing messages.
> >
> > Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
> > ---
> > drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
> > drivers/net/wireless/rt2x00/rt2x00.h | 2 --
> > drivers/net/wireless/rt2x00/rt2x00dev.c | 4 ++--
> > 3 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> > index a1de95e..1791260 100644
> > --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> > +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> > @@ -80,7 +80,7 @@ static inline bool rt2800_is_305x_soc(struct rt2x00_dev *rt2x00dev)
> > rt2x00_rf(rt2x00dev, RF3022))
> > return true;
> >
> > - NOTICE(rt2x00dev, "Unknown RF chipset on rt305x\n");
> > + INFO(rt2x00dev, "Unknown RF chipset on rt305x\n");
> > return false;
> > }
>
> Isn't this more a warning?
Yeah, I'll change that patch.
Stanislaw
next prev parent reply other threads:[~2013-01-26 17:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 20:59 [PATCH 1/4] rt2x00: print warning, notice and info as default Stanislaw Gruszka
2013-01-24 21:00 ` [PATCH 2/4] rt2x00: remove NOTICE Stanislaw Gruszka
2013-01-24 21:01 ` [PATCH 3/4] rt2800usb: move "TX status missed" messages to debug level Stanislaw Gruszka
2013-01-24 21:01 ` [PATCH 4/4] rt2x00: print queue parameters at " Stanislaw Gruszka
2013-01-24 21:07 ` Gertjan van Wingerde
2013-01-26 17:16 ` Ivo Van Doorn
2013-01-24 21:07 ` [PATCH 3/4] rt2800usb: move "TX status missed" messages to " Gertjan van Wingerde
2013-01-26 17:15 ` Ivo Van Doorn
2013-01-24 21:06 ` [PATCH 2/4] rt2x00: remove NOTICE Gertjan van Wingerde
2013-01-25 12:28 ` Ivo Van Doorn
2013-01-26 17:09 ` Stanislaw Gruszka [this message]
2013-01-26 17:13 ` [PATCH 2/4 v2] " Stanislaw Gruszka
2013-01-26 17:14 ` Ivo Van Doorn
2013-01-24 21:06 ` [PATCH 1/4] rt2x00: print warning, notice and info as default Gertjan van Wingerde
2013-01-25 8:46 ` Helmut Schaa
2013-01-25 8:51 ` Gertjan van Wingerde
2013-01-25 8:52 ` Helmut Schaa
2013-02-02 23:50 ` Xose Vazquez Perez
2013-02-02 23:53 ` Xose Vazquez Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130126170948.GA5834@localhost.localdomain \
--to=stf_xl@wp.pl \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.