From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: mvebu: Do not gate ge0/1 and runit clocks on Kirkwood
Date: Sun, 27 Jan 2013 16:28:37 +0100 [thread overview]
Message-ID: <20130127152837.GI29973@lunn.ch> (raw)
In-Reply-To: <51050B9E.8000605@gmail.com>
> Except for loosing the MAC address, I disagree. From a "clock gating"
> point-of-view all kirkwoods (except that crippled one on keymile board)
> are the same. Even if there is no/one/two ethernet _jacks_ on a specific
> board you still want to disable all _unused_ ethernet modules inside the
> SoC.
>
> We should find a way to retain the MAC address and in the meantime we
> can add a "always prepare ge clocks" workaround in
> kirkwood_clk_legacy_init().
Hi Sebastian
I've been thinking the same, store the MAC address before turning the
clock off and restore it when enabling the clock. We have a need for
special clocks on kirkwood anyway for turning off the sata and pcie
PHYs. So adding special clocks for ethernet is not too big a deal.
Andrew
next prev parent reply other threads:[~2013-01-27 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 19:01 [PATCH] clk: mvebu: Do not gate ge0/1 and runit clocks on Kirkwood Simon Baatz
2013-01-26 23:50 ` Jason Cooper
2013-01-27 1:31 ` Simon Baatz
2013-01-27 10:15 ` Sebastian Hesselbarth
2013-01-27 10:56 ` Simon Baatz
2013-01-27 11:12 ` Sebastian Hesselbarth
2013-01-27 15:28 ` Andrew Lunn [this message]
2013-01-27 15:38 ` Sebastian Hesselbarth
2013-01-27 15:41 ` Thomas Petazzoni
2013-01-27 16:41 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127152837.GI29973@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.