From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: fangxiaozhi 00110321 <fangxiaozhi@huawei.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
zihan@huawei.com, Lin.Lei@huawei.com, greg@kroah.com,
neil.yi@huawei.com, wangyuhua@huawei.com, huqiao36@huawei.com,
balbi@ti.com, mdharm-usb@one-eyed-alien.net
Subject: Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match rules
Date: Sun, 27 Jan 2013 19:42:29 +0100 [thread overview]
Message-ID: <20130127184229.GA7163@breakpoint.cc> (raw)
In-Reply-To: <fe6cef496609.6609fe6cef49@huawei.com>
On Fri, Jan 25, 2013 at 10:44:50AM +0800, fangxiaozhi 00110321 wrote:
> diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usual-tables.c linux-3.8-rc4/drivers/usb/storage/usual-tables.c
> --- linux-3.8-rc4_orig/drivers/usb/storage/usual-tables.c 2013-01-22 14:12:42.594238726 +0800
> +++ linux-3.8-rc4/drivers/usb/storage/usual-tables.c 2013-01-22 14:16:01.426250199 +0800
> @@ -41,6 +41,19 @@
> #define USUAL_DEV(useProto, useTrans) \
> { USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, useProto, useTrans) }
>
> +/* Define the device is matched with Vendor ID and interface descriptors */
> +#define UNUSUAL_VENDOR_INTF(id_vendor, cl, sc, pr, \
> + vendorName, productName, useProtocol, useTransport, \
> + initFunction, flags) \
> +{ \
> + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO \
> + | USB_DEVICE_ID_MATCH_VENDOR, \
> + .idVendor = (id_vendor), \
> + .bInterfaceClass = (cl), \
> + .bInterfaceSubClass = (sc), \
> + .bInterfaceProtocol = (pr), \
> + .driver_info = (flags) }
The braces aren't required and you did not need in UNUSUAL_VENDOR_INTF.
Sebastian
next prev parent reply other threads:[~2013-01-27 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 2:44 [PATCH 1/2]linux-usb:Define a new macro for USB storage match rules fangxiaozhi 00110321
2013-01-25 12:18 ` Sergei Shtylyov
2013-01-25 17:44 ` Greg KH
2013-01-26 1:39 ` Fangxiaozhi (Franko)
2013-01-26 2:05 ` Greg KH
2013-01-26 3:10 ` Matthew Dharm
2013-01-26 3:38 ` Greg KH
2013-01-27 18:42 ` Sebastian Andrzej Siewior [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-04 7:14 fangxiaozhi 00110321
2012-12-18 2:42 fangxiaozhi 00110321
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127184229.GA7163@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=Lin.Lei@huawei.com \
--cc=balbi@ti.com \
--cc=fangxiaozhi@huawei.com \
--cc=greg@kroah.com \
--cc=huqiao36@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=neil.yi@huawei.com \
--cc=wangyuhua@huawei.com \
--cc=zihan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.