Re: [PATCH] mwl8k: Announcing AP_VLAN suport

[Yogesh Ashok Powar <yogeshp@marvell.com>]

> >  	if (priv->ap_macids_supported || priv->device_info->fw_image_ap) {
> >  		hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP);
> > +		hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN);
> >  		hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_STATION);
> 
> Hmm, why is this needed? mac80211 should add it:
> 
>         /* if low-level driver supports AP, we also support VLAN */
>         if (local->hw.wiphy->interface_modes & BIT(NL80211_IFTYPE_AP)) {
>                 hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN);
>                 hw->wiphy->software_iftypes |= BIT(NL80211_IFTYPE_AP_VLAN);
>         }
> 
> Is this run too late, i.e. after registering hw? If so, that's a bug.

Hi Johannes,

   We agree with you. There is no need to explicitly set
NL80211_IFTYPE_AP_VLAN support for AP driver. This patch
is redundant.

@John: Please ignore this patch.

Thanks
Yogesh

> 
> johannes
>