From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Henrik Rydberg" Subject: Re: [PATCH 06/25] HID: multitouch: optimize FlatFrog panels Date: Mon, 28 Jan 2013 16:10:10 +0100 Message-ID: <20130128151010.GA3470@polaris.bitmath.org> References: <1359120190-18281-1-git-send-email-benjamin.tissoires@gmail.com> <1359120190-18281-7-git-send-email-benjamin.tissoires@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtprelay-h21.telenor.se ([195.54.99.196]:60230 "EHLO smtprelay-h21.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681Ab3A1PE5 (ORCPT ); Mon, 28 Jan 2013 10:04:57 -0500 Content-Disposition: inline In-Reply-To: <1359120190-18281-7-git-send-email-benjamin.tissoires@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benjamin Tissoires Cc: Dmitry Torokhov , Jiri Kosina , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Hi Benjamin, > Relying on ALWAYS_VALID enhance a little the processing time of > the events. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-multitouch.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Is there a measurement backing up this claim? I suspect micro-optimizations of this kind drowns completely along the rather long way from device, via malloc and loops, to the input core. Considering the must-be-tested-for-regression risk on top of that, this patch falls far below what is worth doing, IMHO. > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 5a886bd..7dfe891 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -229,8 +229,9 @@ static struct mt_class mt_classes[] = { > }, > > { .name = MT_CLS_FLATFROG, > - .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | > - MT_QUIRK_NO_AREA, > + .quirks = MT_QUIRK_ALWAYS_VALID | > + MT_QUIRK_NO_AREA | > + MT_QUIRK_CONTACT_CNT_ACCURATE, > .sn_move = 2048, > .maxcontacts = 40, > }, > -- > 1.8.1 > Thanks. Henrik