Re: [PATCH v2 5/6] Misc: display unsigned hex

["Amaury Decrême" <amaury.decreme-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Mon, Jan 28, 2013 at 07:33:04PM +0100, Jean Delvare wrote:
> > -		dev_dbg(&adap->dev, "SMBus busy (%02x). Resetting...\n", temp);
> > +		dev_dbg(&adap->dev, "SMBus busy (%02hx). Resetting...\n", temp);
> 
> %hx is for shorts, not bytes. There is no format specifier for shorts,
> so a cast is always needed for these if you want to be strictly
> compliant. In practice gcc is smart enough to do the cast
> automatically. Same for most cases below.
> 
> My suggestion to use %hx was really only for the cases where the
> variable is an unsigned short or u16, you can leave all the rest as is.
> 

I indeed missed that point. Corrected.

-- 
Amaury Decrême