All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/2 V2] xfs_logprint: Handle multiply-logged inode fields
Date: Mon, 28 Jan 2013 15:31:27 -0600	[thread overview]
Message-ID: <20130128213127.GD27055@sgi.com> (raw)
In-Reply-To: <5106E3EE.2030601@redhat.com>

On Mon, Jan 28, 2013 at 02:47:42PM -0600, Eric Sandeen wrote:
> On 1/22/13 3:05 PM, Dave Chinner wrote:
> > On Tue, Jan 22, 2013 at 11:55:30AM -0600, Ben Myers wrote:
> >> Hey Eric,
> >>
> >> On Thu, Nov 01, 2012 at 11:33:46AM -0500, Eric Sandeen wrote:
> >>> As xlog_print_trans_inode() stands today, it will error
> >>> out if more than one flag is set on f->ilf_fields:
> >>>
> >>> 	xlog_print_trans_inode: illegal inode type
> >>>
> >>> but this is a perfectly valid case, to have i.e. a data and
> >>> an attr flag set.
> >>>
> >>> Following is a pretty big reworking of the function to
> >>> handle more than one field type set.
> >>
> >> I'm trying to wrap my head around this one.  I have a few stupid questions.
> >>
> >>> I've tested this by a simple test such as creating one
> >>> file on an selinux box, so that data+attr is set, and
> >>> logprinting; I've also tested by running logprint after
> >>> subsequent xfstest runs (although we hit other bugs that
> >>> way).
> >>>
> >>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >>> ---
> 
> Ben, Mark -
> 
> Where are we at with this one?  We have a partner who is interested in the fix.
> Do you want anything more from me before it can be merged?

Hey Eric,

I think it's ready to be merged... It looks like you reposted Jan 02 and I
replied to the wrong one.  If that code isn't significantly different we're
good to go.

Thanks,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-01-28 21:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 16:22 [PATCH 0/2] xfsdump: 2 fixes Eric Sandeen
2012-11-01 16:26 ` [PATCH 1/2] xfsdump: Handle multiply-logged inode fields Eric Sandeen
2012-11-01 16:33   ` [PATCH 1/2 V2] xfs_logprint: " Eric Sandeen
2012-11-02 13:01     ` Christoph Hellwig
2012-11-02 14:39       ` Eric Sandeen
     [not found]     ` <20130122175530.GR27055@sgi.com>
     [not found]       ` <20130122210511.GK2498@dastard>
2013-01-28 20:47         ` Eric Sandeen
2013-01-28 21:31           ` Ben Myers [this message]
2012-11-01 16:32 ` [PATCH 2/2] xfs_logprint: Handle continued inode transactions Eric Sandeen
2012-11-02 13:04   ` Christoph Hellwig
2012-11-02 14:35     ` Eric Sandeen
2012-11-01 16:33 ` [PATCH 0/2] xfs_logprint: 2 fixes Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130128213127.GD27055@sgi.com \
    --to=bpm@sgi.com \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.