From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/4] drm/i915: move modeset checks out of
 save/restore_modeset_reg
Date: Mon, 28 Jan 2013 22:54:54 +0100
Message-ID: <20130128215454.GD14766@phenom.ffwll.local>
References: <1359132802-1247-1-git-send-email-daniel.vetter@ffwll.ch>
	<1359132802-1247-2-git-send-email-daniel.vetter@ffwll.ch>
	<1359370466.3592.7.camel@ideak-mobl>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id E6CC9E62C6
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 28 Jan 2013 13:52:47 -0800 (PST)
Received: by mail-ea0-f177.google.com with SMTP id n13so1337556eaa.8
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 28 Jan 2013 13:52:47 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1359370466.3592.7.camel@ideak-mobl>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Imre Deak <imre.deak@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jan 28, 2013 at 12:54:26PM +0200, Imre Deak wrote:
> On Fri, 2013-01-25 at 17:53 +0100, Daniel Vetter wrote:
> > That way the control flow is clearer, and it prepares the stage
> > to extract these ums functions and hide them somewhere.
> > 
> > There's still tons of display stuff outside of these, but that
> > requires more work.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> s/modeset/display/ as discussed on IRC. Also would be nice to use
> format-patch -C for things like patch 2/4 in the future, as that'd make
> reviewing easier imo. Otherwise on the series:
> 
> Reviewed-by: Imre Deak <imre.deak@intel.com>

Ok, slurped in the entire series, with your suggestion applied to patch 2
(less conflicts that way to resolve). Thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch