From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 11/12] ext4: Make ext4_bio_writepage() handle unprepared buffers
Date: Mon, 28 Jan 2013 20:59:46 -0500 [thread overview]
Message-ID: <20130129015946.GB7003@thunk.org> (raw)
In-Reply-To: <1358510446-19174-12-git-send-email-jack@suse.cz>
On Fri, Jan 18, 2013 at 01:00:45PM +0100, Jan Kara wrote:
> So far ext4_bio_writepage() unconditionally cleared dirty bit on all buffers
> underlying the page. That implicitely assumes we can write all buffers. So
> far that is true because callers call into ext4_bio_writepage() make sure
> all buffers in the page are mapped but
> a) it's a data corruption bug waiting to happen
> b) in data=ordered mode when blocksize < pagesize we do need to write pages
> that may have only some of dirty buffers mapped.
>
> So change ext4_bio_writepage() to skip buffers that cannot be written without
> clearing their dirty bit.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2013-01-29 1:59 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 12:00 [PATCH 0/12 v2] ext4: Several simplifications and fixes Jan Kara
2013-01-18 12:00 ` [PATCH 01/12] ext4: Always use ext4_bio_write_page() for writeout Jan Kara
2013-01-28 14:31 ` Theodore Ts'o
2013-01-18 12:00 ` [PATCH 02/12] ext4: Use redirty_page_for_writepage() in ext4_bio_write_page() Jan Kara
2013-01-28 14:34 ` Theodore Ts'o
2013-01-18 12:00 ` [PATCH 03/12] ext4: Remove bogus wait for unwritten extents in ext4_ind_direct_IO Jan Kara
2013-01-22 11:11 ` Dmitry Monakhov
2013-01-22 13:44 ` Jan Kara
2013-01-22 14:12 ` Dmitry Monakhov
2013-01-22 15:21 ` Jan Kara
2013-01-22 14:22 ` Zheng Liu
2013-01-22 15:22 ` Jan Kara
2013-01-22 16:00 ` Zheng Liu
2013-01-22 23:14 ` Jan Kara
2013-01-23 6:11 ` Zheng Liu
2013-01-23 9:42 ` Jan Kara
2013-01-18 12:00 ` [PATCH 04/12] ext4: Disable merging of uninitialized extents Jan Kara
2013-01-24 9:49 ` Dmitry Monakhov
2013-01-24 15:12 ` Jan Kara
2013-01-24 15:32 ` Dmitry Monakhov
2013-01-28 14:36 ` Theodore Ts'o
2013-01-28 15:02 ` Dmitry Monakhov
2013-01-28 15:38 ` Theodore Ts'o
2013-01-29 7:41 ` Dmitry Monakhov
2013-01-29 8:37 ` Zheng Liu
2013-01-31 7:47 ` Dmitry Monakhov
2013-01-31 12:39 ` Jan Kara
2013-01-31 14:09 ` Dmitry Monakhov
2013-01-31 16:54 ` Theodore Ts'o
2013-02-09 17:10 ` REGRESSION: " Theodore Ts'o
2013-02-12 21:58 ` Jan Kara
2013-02-13 4:57 ` Theodore Ts'o
2013-02-13 7:26 ` Dmitry Monakhov
2013-02-13 15:08 ` Merge window planning for ext4 and Ted's vacation Theodore Ts'o
2013-02-14 10:47 ` REGRESSION: [PATCH 04/12] ext4: Disable merging of uninitialized extents Jan Kara
2013-02-14 16:11 ` Jan Kara
2013-02-14 19:05 ` Theodore Ts'o
2013-02-14 21:32 ` Jan Kara
2013-01-18 12:00 ` [PATCH 05/12] ext4: Remove unnecessary wait for extent conversion in ext4_fallocate() Jan Kara
2013-01-18 12:00 ` [PATCH 06/12] ext4: Move work from io_end to inode Jan Kara
2013-01-28 14:45 ` Theodore Ts'o
2013-01-18 12:00 ` [PATCH 07/12] ext4: Simplify list handling in ext4_do_flush_completed_IO() Jan Kara
2013-01-28 14:51 ` Theodore Ts'o
2013-01-18 12:00 ` [PATCH 08/12] ext4: Remove __ext4_journalled_writepage() from mpage_da_submit_io() Jan Kara
2013-01-28 14:40 ` Theodore Ts'o
2013-01-18 12:00 ` [PATCH 09/12] ext4: Dirty page has always buffers attached Jan Kara
2013-01-28 17:55 ` Theodore Ts'o
2013-01-18 12:00 ` [PATCH 10/12] ext4: Simplify mpage_add_bh_to_extent() Jan Kara
2013-01-28 18:06 ` Theodore Ts'o
2013-01-18 12:00 ` [PATCH 11/12] ext4: Make ext4_bio_writepage() handle unprepared buffers Jan Kara
2013-01-29 1:59 ` Theodore Ts'o [this message]
2013-01-18 12:00 ` [PATCH 12/12] ext4: Fix ext4_writepage() to achieve data=ordered guarantees Jan Kara
2013-01-29 2:08 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129015946.GB7003@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.