All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joe Millenbach <jmillenbach@gmail.com>
Cc: Josh Triplett <josh@joshtriplett.org>, Greg KH <greg@kroah.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Brian Swetland <swetland@google.com>,
	"Mike A. Chan" <mikechan@google.com>,
	Sheng Yang <sheng@linux.intel.com>,
	Yunhong Jiang <yunhong.jiang@intel.com>,
	Xiaohui Xin <xiaohui.xin@intel.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Bruce Beare <bruce.j.beare@intel.com>,
	Tom Keel <thomas.keel@intel.com>, Alan Cox <alan@linux.intel.com>,
	Jamey Sharp <jamey@minilop.net>
Subject: Re: linux-next: manual merge of the tty tree with the input tree
Date: Mon, 28 Jan 2013 22:38:03 -0800	[thread overview]
Message-ID: <20130129063803.GC5797@core.coreip.homeip.net> (raw)
In-Reply-To: <CADwDc1CbNeDSNKDh0a01Nde7Mpz3xT6XpsTY4nui8DVt6M40Mw@mail.gmail.com>

Hi Joe,

On Mon, Jan 28, 2013 at 10:26:47PM -0800, Joe Millenbach wrote:
> On Mon, Jan 28, 2013 at 9:33 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > Please revert the input changes and add *ONE* new dependency to the
> > serport driver.
> >
> > Thanks.
> >
> > --
> > Dmitry
> 
> Apologies on this.  I must have misunderstood the problem originally,
> and I definitely misunderstood your solution until I looked at it
> again.  I just went through applying the changes I'd created minus the
> driver/input changes, plus your SERPORT TTY dependency.  You were
> right that it solves the dependency issue and is much more elegant.  I
> thought it was going to leave dangling select dependencies for users
> to deal with later.  Sorry I was so hesitant at first.
> 
> I'll be making up a new patch for Greg after I get it reviewed.

Thank you for making the changes.

By the "dangling select dependencies" I assume you mean "select SERIO"
that several drivers do? "select SERIO" selects only serio core which is
self contained and has no additional dependencies [so far], that is why
it is being selected rather than being depended upon.

Thanks.

-- 
Dmitry

      reply	other threads:[~2013-01-29  6:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28  9:44 linux-next: manual merge of the tty tree with the input tree Stephen Rothwell
2013-01-28 14:46 ` Greg KH
2013-01-28 17:33   ` Dmitry Torokhov
2013-01-28 22:09     ` Joe Millenbach
2013-01-28 22:44       ` Dmitry Torokhov
2013-01-28 23:59         ` Josh Triplett
2013-01-29  0:23           ` Dmitry Torokhov
2013-01-29  5:13             ` Josh Triplett
2013-01-29  5:33               ` Dmitry Torokhov
2013-01-29  6:26                 ` Joe Millenbach
2013-01-29  6:38                   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130129063803.GC5797@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=alan@linux.intel.com \
    --cc=bruce.j.beare@intel.com \
    --cc=greg@kroah.com \
    --cc=jamey@minilop.net \
    --cc=jmillenbach@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=jun.nakajima@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mikechan@google.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sheng@linux.intel.com \
    --cc=swetland@google.com \
    --cc=thomas.keel@intel.com \
    --cc=xiaohui.xin@intel.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.