From: Jens Axboe <axboe@kernel.dk>
To: Ken Raeburn <raeburn@permabit.com>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] Fix crash with absurdly but not impossibly deeply nested device stacks.
Date: Tue, 29 Jan 2013 10:17:12 +0100 [thread overview]
Message-ID: <20130129091712.GD30188@kernel.dk> (raw)
In-Reply-To: <6ea9rsrc7u.fsf@just-testing.permabit.com>
On Mon, Jan 28 2013, Ken Raeburn wrote:
> diskutil.c: Check for overflow in disk_util.path.
> diskutil.h: Expand disk_util.path to PATH_MAX.
Good stuff, thanks. Though I think that we should just return NULL on
failing to setup the path.
And:
> + l = snprintf(du->path, sizeof(du->path), "%s/stat", path);
> + if (l < 0 || l >= sizeof(du->path)) {
cosmetically, that should never be > sizeof(du->path), but it doesn't
hurt.
--
Jens Axboe
next prev parent reply other threads:[~2013-01-29 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 1:24 path name lengths Ken Raeburn
2013-01-29 1:48 ` [PATCH] Fix crash with absurdly but not impossibly deeply nested device stacks Ken Raeburn
2013-01-29 9:17 ` Jens Axboe [this message]
2013-01-29 9:19 ` Jens Axboe
2013-01-29 21:06 ` Ken Raeburn
2013-01-29 21:15 ` Jens Axboe
2013-01-29 22:09 ` Ken Raeburn
2013-01-30 11:58 ` Jens Axboe
2013-01-30 21:25 ` [PATCH] Fix bugs in [v]snprintf usage Ken Raeburn
2013-01-30 21:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129091712.GD30188@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=raeburn@permabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.