From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steffen Klassert Subject: Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues Date: Tue, 29 Jan 2013 10:33:31 +0100 Message-ID: <20130129093331.GA23291@secunet.com> References: <20130124094337.GJ9147@secunet.com> <20130124112410.8535.75598.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Herbert Xu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Tom St Denis , David Miller To: Jussi Kivilinna Return-path: Received: from a.mx.secunet.com ([195.81.216.161]:46500 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870Ab3A2Jde (ORCPT ); Tue, 29 Jan 2013 04:33:34 -0500 Content-Disposition: inline In-Reply-To: <20130124112410.8535.75598.stgit@localhost6.localdomain6> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Jan 24, 2013 at 01:25:46PM +0200, Jussi Kivilinna wrote: > > Maybe it would be cleaner to not mess with pfkeyv2.h at all, but instead mark algorithms that do not support pfkey with flag. See patch below. > As nobody seems to have another opinion, we could go either with your approach, or we can invert the logic and mark all existing algorithms as pfkey supported. Then we would not need to bother about pfkey again. I'd be fine with both. Do you want to submit a patch? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753311Ab3A2Jdj (ORCPT ); Tue, 29 Jan 2013 04:33:39 -0500 Received: from a.mx.secunet.com ([195.81.216.161]:46500 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870Ab3A2Jde (ORCPT ); Tue, 29 Jan 2013 04:33:34 -0500 Date: Tue, 29 Jan 2013 10:33:31 +0100 From: Steffen Klassert To: Jussi Kivilinna Cc: Herbert Xu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Tom St Denis , David Miller Subject: Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues Message-ID: <20130129093331.GA23291@secunet.com> References: <20130124094337.GJ9147@secunet.com> <20130124112410.8535.75598.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130124112410.8535.75598.stgit@localhost6.localdomain6> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginalArrivalTime: 29 Jan 2013 09:33:31.0884 (UTC) FILETIME=[B3D1CAC0:01CDFE03] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 24, 2013 at 01:25:46PM +0200, Jussi Kivilinna wrote: > > Maybe it would be cleaner to not mess with pfkeyv2.h at all, but instead mark algorithms that do not support pfkey with flag. See patch below. > As nobody seems to have another opinion, we could go either with your approach, or we can invert the logic and mark all existing algorithms as pfkey supported. Then we would not need to bother about pfkey again. I'd be fine with both. Do you want to submit a patch?