From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH 2/2] perf: Make -lnuma optional
Date: Tue, 29 Jan 2013 11:49:58 +0100 [thread overview]
Message-ID: <20130129104958.GC14302@pd.tnic> (raw)
In-Reply-To: <1359456492-22156-2-git-send-email-bp@alien8.de>
On Tue, Jan 29, 2013 at 11:48:12AM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> a0c17eadf3bf9 ("perf: Add 'perf bench numa mem' NUMA performance
> measurement suite") added -lnuma to the EXTLIBS but we use those when
> checking for other libraries like libelf, libunwind, etc and the checks
> failed even when the dev libraries are installed on the system:
>
> CHK libelf
> /usr/bin/ld: cannot find -lnuma
> collect2: error: ld returned 1 exit status
> CHK glibc
> Makefile:552: No libelf found, disables 'probe' tool, please install elfutils-libelf-devel/libelf-dev
> CHK libunwind
> /usr/bin/ld: cannot find -lnuma
> collect2: error: ld returned 1 exit status
> Makefile:586: No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 0.99
> ...
>
> So, add glue to detect the presence of -lnuma and build perf bench numa
> only then.
While at it, I noticed another annoyance: if FLEX and BISON are needed
unconditionally for the build, this needs to be checked at the beginning
of the makefile and make shouldn't fail in-between. Oh well, I'll let
someone beat me to it with a fix since I'm lazy :).
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
prev parent reply other threads:[~2013-01-29 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 10:48 [PATCH 2/2] perf: Make -lnuma optional Borislav Petkov
2013-01-29 10:49 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129104958.GC14302@pd.tnic \
--to=bp@alien8.de \
--cc=acme@redhat.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.