From: Jan Kara <jack@suse.cz>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] Ext3: remove a useless check for the function ext3_free_blocks_sb
Date: Tue, 29 Jan 2013 15:40:14 +0100 [thread overview]
Message-ID: <20130129144014.GE32246@quack.suse.cz> (raw)
In-Reply-To: <510765B1.7000100@gmail.com>
On Mon 28-01-13 22:01:21, Wang Shilong wrote:
> 于 2013-1-28 6:07, Jan Kara 写道:
> > On Sat 26-01-13 14:58:31, Wang Shilong wrote:
> >> From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
> >>
> >> Because 'block + count < block' always comes to false, it is useless
> >> to have this check, just remove it.
> > As Andreas commented, the test is actually correct. BTW any reason why
> > you sent the patch three times?
> My linux run in the virtual machine..and the clock is wrong...so i send the patch not clarified correctly
> in marc.info..when i find it..I correct it, but first time i correct the time as 2012....how stupid it was..:-[
> so i send the patch three times...sorry to bother...
>
> BTW ， may i have a question....
> As we know the block to be freed can not be superblock and GDT..
> I don't see any check about it in ext2/ext3/ext4....
Yes, you are right we apparently don't check for superblock or GDT
blocks. But checking for those will be a bit more complex and they are
really scarce so I don't think it's worth the overhead.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-29 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 22:58 [PATCH 2/2] Ext3: remove a useless check for the function ext3_free_blocks_sb Wang Shilong
2013-01-28 14:07 ` Jan Kara
2013-01-29 6:01 ` Wang Shilong
2013-01-29 14:40 ` Jan Kara [this message]
2013-01-29 17:08 ` Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 22:55 Wang Shilong
2011-01-26 22:48 Wang Shilong
2013-01-27 7:40 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129144014.GE32246@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.