From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Error state should print
 /sys/kernel/debug
Date: Tue, 29 Jan 2013 19:05:27 +0200
Message-ID: <20130129170527.GS9135@intel.com>
References: <1359415936-2732-1-git-send-email-ben@bwidawsk.net>
	<20130129084112.GG6187@dyon.amr.corp.intel.com>
	<20130129085418.GF14766@phenom.ffwll.local>
	<20130129085236.00001740@unknown>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id F0C8DE68AD
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 29 Jan 2013 09:05:30 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20130129085236.00001740@unknown>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jan 29, 2013 at 08:52:36AM -0800, Ben Widawsky wrote:
> On Tue, 29 Jan 2013 09:54:18 +0100
> Daniel Vetter <daniel@ffwll.ch> wrote:
> =

> > On Tue, Jan 29, 2013 at 08:41:12AM +0000, Damien Lespiau wrote:
> > > On Mon, Jan 28, 2013 at 03:32:15PM -0800, Ben Widawsky wrote:
> > > > /sys/kernel/debug has more or less been the standard location of
> > > > debugfs for several years now. Other parts of DRM already use
> > > > this location, so we should as well.
> > > > =

> > > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > > =

> > > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> > =

> > Queued for -next, thanks for the patch. Oh and fixed up a bikeshed
> > from checkpatch.pl while applying:
> > =

> > Applying: drm/i915: Error state should print /sys/kernel/debug
> > WARNING: line over 80 characters
> > #22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308:
> > +       DRM_INFO("capturing error event; look for more information
> > in /sys/kernel/debug/dri/%d/i915_error_state\n",
> > =

> > total: 0 errors, 1 warnings, 8 lines checked
> > =

> > Yeah, I've added that OCD thing to my patch apply pipeline, let's see
> > how much fun it is ;-)
> =

> I've not looked at the final patch yet, but I think breaking up
> constant strings is considered bad form, and lines above 80 are
> generally favored for grepability.
> =

> At least James Bottomley said that in his talk and LPC, and a bunch of
> other maintainers seemed to agree. (and I agree)

I routinely ignore the 80 cols warnings. I'm sure a significant part
of my patches violate it, even the ones w/o long strings.

-- =

Ville Syrj=E4l=E4
Intel OTC