From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] tcm_vhost: Optimize gup in vhost_scsi_map_to_sgl
Date: Tue, 29 Jan 2013 21:16:59 +0200 [thread overview]
Message-ID: <20130129191659.GA29615@redhat.com> (raw)
In-Reply-To: <1359485613.23290.1389.camel@haakon2.linux-iscsi.org>
On Tue, Jan 29, 2013 at 10:53:33AM -0800, Nicholas A. Bellinger wrote:
> On Tue, 2013-01-22 at 11:20 +0800, Asias He wrote:
> > We can get all the pages in one time instead of calling
> > gup N times.
> >
> > Signed-off-by: Asias He <asias@redhat.com>
> > ---
>
> Everything looks fine after initial testing, so also applied to
> target-pending/for-next.
>
> Nice optimization. :)
>
> --nab
Maybe best if you put the llist optimization on that branch too then?
next prev parent reply other threads:[~2013-01-29 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 3:20 [PATCH v2 0/3] tcm_vhost: Optimize gup in vhost_scsi_map_to_sgl Asias He
2013-01-22 3:20 ` [PATCH v2 1/3] tcm_vhost: Introduce iov_num_pages Asias He
2013-01-29 18:51 ` Nicholas A. Bellinger
2013-01-22 3:20 ` [PATCH v2 2/3] tcm_vhost: Use iov_num_pages to calculate sgl_count Asias He
2013-01-22 3:20 ` Asias He
2013-01-29 18:52 ` Nicholas A. Bellinger
2013-01-22 3:20 ` [PATCH v2 3/3] tcm_vhost: Optimize gup in vhost_scsi_map_to_sgl Asias He
2013-01-22 3:20 ` Asias He
2013-01-29 18:53 ` Nicholas A. Bellinger
2013-01-29 19:16 ` Michael S. Tsirkin [this message]
2013-01-29 19:21 ` Nicholas A. Bellinger
2013-01-29 19:21 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129191659.GA29615@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.