Re: [PATCH 2/2] nfsd: Fix memleak.

[bfields <bfields@fieldses.org>]

Tejun, maybe this could be added to your series?

(Or should I just take it without the idr_remove_all()?)

--b.

On Tue, Jan 29, 2013 at 01:16:06PM +0800, majianpeng wrote:
> When free nfs-client, it must free the ->cl_stateids.
> 
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
>  fs/nfsd/nfs4state.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index ac8ed96..a8309c6 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1060,6 +1060,8 @@ free_client(struct nfs4_client *clp)
>  	}
>  	free_svc_cred(&clp->cl_cred);
>  	kfree(clp->cl_name.data);
> +	idr_remove_all(&clp->cl_stateids);
> +	idr_destroy(&clp->cl_stateids);
>  	kfree(clp);
>  }
>  
> -- 
> 1.7.9.5