From: Ben Myers <bpm@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: fugazzi® <fugazzi99@gmail.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: test dump/restore of file capabilities
Date: Tue, 29 Jan 2013 16:44:20 -0600 [thread overview]
Message-ID: <20130129224420.GL27055@sgi.com> (raw)
In-Reply-To: <50E61CC3.1000108@redhat.com>
Eric,
On Thu, Jan 03, 2013 at 06:05:23PM -0600, Eric Sandeen wrote:
> xfsrestore isn't properly restoring file capabilities; it restores
> them, but then chowns the file, which removes the caps:
>
> Call Trace:
> [<ffffffffa028de68>] xfs_xattr_set+0x118/0x120 [xfs]
> [<ffffffff8119a8c0>] generic_removexattr+0x80/0x90
> [<ffffffff8120b408>] cap_inode_killpriv+0x28/0x30
> [<ffffffff8120c666>] security_inode_killpriv+0x16/0x20
> [<ffffffff81192edf>] notify_change+0x18f/0x330
> [<ffffffff81176b70>] chown_common+0x60/0xa0
> [<ffffffff81176c30>] sys_fchown+0x80/0xd0
> [<ffffffff81537c59>] system_call_fastpath+0x16/0x1b
>
> This test demonstrates the problem.
>
> Reported-by: fugazzi® <fugazzi99@gmail.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
This looks good to me.
Reviewed-by: Ben Myers <bpm@sgi.com>
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next parent reply other threads:[~2013-01-29 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50E61CC3.1000108@redhat.com>
2013-01-29 22:44 ` Ben Myers [this message]
2013-01-30 18:18 ` [PATCH] xfstests: test dump/restore of file capabilities Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129224420.GL27055@sgi.com \
--to=bpm@sgi.com \
--cc=fugazzi99@gmail.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.