From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Myers Subject: Re: [PATCH 2/4] xfs: Fix possible use-after-free with AIO Date: Tue, 29 Jan 2013 18:56:56 -0600 Message-ID: <20130130005656.GM27055@sgi.com> References: <1359502081-20240-1-git-send-email-jack@suse.cz> <1359502081-20240-3-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , stable@vger.kernel.org, xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com To: Jan Kara Return-path: Received: from relay1.sgi.com ([192.48.179.29]:42140 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022Ab3A3A5B (ORCPT ); Tue, 29 Jan 2013 19:57:01 -0500 Content-Disposition: inline In-Reply-To: <1359502081-20240-3-git-send-email-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: Hi Jan, On Wed, Jan 30, 2013 at 12:27:59AM +0100, Jan Kara wrote: > Running AIO is pinning inode in memory using file reference. Once AIO > is completed using aio_complete(), file reference is put and inode can > be freed from memory. So we have to be sure that calling aio_complete() > is the last thing we do with the inode. > > CC: xfs@oss.sgi.com > CC: Ben Myers > CC: stable@vger.kernel.org > Reviewed-by: Ben Myers > Acked-by: Jeff Moyer > Signed-off-by: Jan Kara We picked this up in the xfs tree. Sorry to keep you hanging. Regards, Ben From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 9FA967F4E for ; Tue, 29 Jan 2013 18:57:00 -0600 (CST) Date: Tue, 29 Jan 2013 18:56:56 -0600 From: Ben Myers Subject: Re: [PATCH 2/4] xfs: Fix possible use-after-free with AIO Message-ID: <20130130005656.GM27055@sgi.com> References: <1359502081-20240-1-git-send-email-jack@suse.cz> <1359502081-20240-3-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1359502081-20240-3-git-send-email-jack@suse.cz> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jan Kara Cc: stable@vger.kernel.org, xfs@oss.sgi.com, Al Viro , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com Hi Jan, On Wed, Jan 30, 2013 at 12:27:59AM +0100, Jan Kara wrote: > Running AIO is pinning inode in memory using file reference. Once AIO > is completed using aio_complete(), file reference is put and inode can > be freed from memory. So we have to be sure that calling aio_complete() > is the last thing we do with the inode. > > CC: xfs@oss.sgi.com > CC: Ben Myers > CC: stable@vger.kernel.org > Reviewed-by: Ben Myers > Acked-by: Jeff Moyer > Signed-off-by: Jan Kara We picked this up in the xfs tree. Sorry to keep you hanging. Regards, Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Myers Date: Wed, 30 Jan 2013 00:57:03 -0000 Subject: [Ocfs2-devel] [PATCH 2/4] xfs: Fix possible use-after-free with AIO In-Reply-To: <1359502081-20240-3-git-send-email-jack@suse.cz> References: <1359502081-20240-1-git-send-email-jack@suse.cz> <1359502081-20240-3-git-send-email-jack@suse.cz> Message-ID: <20130130005656.GM27055@sgi.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jan Kara Cc: Al Viro , stable@vger.kernel.org, xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com Hi Jan, On Wed, Jan 30, 2013 at 12:27:59AM +0100, Jan Kara wrote: > Running AIO is pinning inode in memory using file reference. Once AIO > is completed using aio_complete(), file reference is put and inode can > be freed from memory. So we have to be sure that calling aio_complete() > is the last thing we do with the inode. > > CC: xfs at oss.sgi.com > CC: Ben Myers > CC: stable at vger.kernel.org > Reviewed-by: Ben Myers > Acked-by: Jeff Moyer > Signed-off-by: Jan Kara We picked this up in the xfs tree. Sorry to keep you hanging. Regards, Ben