From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: intel-gpu-tools patches for read/write MMIO Date: Tue, 29 Jan 2013 17:12:53 -0800 Message-ID: <20130130011253.GC4469@lundgren.nims.intel.com> References: <20130114073735.60c1f0c7@jbarnes-desktop> <67A6A5BE6078AA49887BBA3935A429881D60A9@PGSMSX103.gar.corp.intel.com> <67A6A5BE6078AA49887BBA3935A429881D636B@PGSMSX103.gar.corp.intel.com> <20130129120109.75f85b33@jbarnes-t420> <51082DDA.60109@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 7188FE5E17 for ; Tue, 29 Jan 2013 17:11:43 -0800 (PST) Content-Disposition: inline In-Reply-To: <51082DDA.60109@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: "Cheah, Vincent Beng Keat" , "Ung, Teng En" , "Teres Alexis, Alan Previn" , "intel-gfx@lists.freedesktop.org" , Jesse Barnes , "Widawsky, Benjamin" List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 29, 2013 at 09:15:22PM +0100, Daniel Vetter wrote: > On 29/01/2013 21:01, Jesse Barnes wrote: > >Can you just post them externally tointel-gfx@lists.freedesktop.org? > >It's best to use git send-email to do it, that way the changelogs are > >preserved and posted to the ml along with the patches. > Public intel-gfx is already on the cc list, just in case you get the > urge to spill some secrets ;-) > >Not sure if there's a bunch of duplication between the two, but you > >could split them up a bit. > > > >I still don't like the idea of silently adding the display offset on > >vlv; these are just debug tools and the developer should get the > >absolute offset they asked for no matter what. > On that topic of silently adding display offset - with Ville's > kernel work we'll have switched away completely from such tricks in > the kernel. So I think i-g-t shouldn't automatically add the offset. > > Which essentially just leaves us with intel_reg_dumper. Now for that > I'm somewhat hopefully that we will be able to (eventually) dump > registers using the bspec xml sources (there should be bspec xmls > around for just the open-source approved parts). In the meantime, > can't we just adjust the relevant offsets of the register blocks? > IIrc their all somewhat usefully grouped together, so this would > amount to adding a quick function to add the offset to a given table > (put keep all the names) and then feed the adjusted table to the > dumper functions ... > -Daniel As we discussed in private, even if we get to the point of having bspec xml, we would still want a tool similar to the one that was proposed for parsing the XML (as opposed to the text). Reg dumper as has been mentioned in several threads is pretty inflexible, and a pain to modify for person use. As we also discussed in private, I'd like Jesse to either fight or not for this because I don't think he has to butt heads with you enough. -- Ben Widawsky, Intel Open Source Technology Center