All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema
Date: Wed, 30 Jan 2013 09:25:34 -0200	[thread overview]
Message-ID: <20130130092534.4836b142@redhat.com> (raw)
In-Reply-To: <8f03011d18d9d8cb51a4c2339f2ae4be7cfe1052.1359478671.git.mprivozn@redhat.com>

On Tue, 29 Jan 2013 17:58:41 +0100
Michal Privoznik <mprivozn@redhat.com> wrote:

> Currently, we are using 'tray_open' in QMP and 'tray-open' in
> HMP. However, the QMP documentation was mistakenly using the
> HMP version.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

> ---
> 
> diff to v1:
> -add S-o-b line
> 
>  qmp-commands.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index f58a841..f90efe5 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1659,7 +1659,7 @@ Each json-object contain the following:
>           - Possible values: "unknown"
>  - "removable": true if the device is removable, false otherwise (json-bool)
>  - "locked": true if the device is locked, false otherwise (json-bool)
> -- "tray-open": only present if removable, true if the device has a tray,
> +- "tray_open": only present if removable, true if the device has a tray,
>                 and it is open (json-bool)
>  - "inserted": only present if the device is inserted, it is a json-object
>     containing the following:



      parent reply	other threads:[~2013-01-30 11:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29 16:58 [Qemu-trivial] [PATCH v2] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema Michal Privoznik
2013-01-29 20:07 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2013-01-30 10:19 ` [Qemu-trivial] " Stefan Hajnoczi
2013-01-30 11:25 ` Luiz Capitulino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130130092534.4836b142@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=mprivozn@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.