From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v6 03/10] ARM: edma: add AM33XX support to the private EDMA API Date: Wed, 30 Jan 2013 09:32:58 +0000 Message-ID: <201301300932.58732.arnd@arndb.de> References: <1359529229-22207-1-git-send-email-mporter@ti.com> <1359529229-22207-4-git-send-email-mporter@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1359529229-22207-4-git-send-email-mporter-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Matt Porter Cc: Linux DaVinci Kernel List , Linux OMAP List , Russell King , Linux Documentation List , Linux MMC List , Devicetree Discuss , Mark Brown , Sekhar Nori , Linux Kernel Mailing List , Rob Herring , Vinod Koul , Dan Williams , Linux SPI Devel List , Chris Ball , Linux ARM Kernel List List-Id: linux-mmc@vger.kernel.org On Wednesday 30 January 2013, Matt Porter wrote: > + dma_cap_set(DMA_SLAVE, edma_filter_info.dma_cap); > + of_dma_controller_register(dev->of_node, > + of_dma_simple_xlate, > + &edma_filter_info); > + } How do you actually deal with the problem mentioned by Padma, that the filter function does not know which edma instance it is looking at? If you assume that there can only be a single edma instance in the system, that is probably a limitation that should be documented somewhere, and ideally the probe() function should check for that. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 30 Jan 2013 09:32:58 +0000 Subject: [PATCH v6 03/10] ARM: edma: add AM33XX support to the private EDMA API In-Reply-To: <1359529229-22207-4-git-send-email-mporter@ti.com> References: <1359529229-22207-1-git-send-email-mporter@ti.com> <1359529229-22207-4-git-send-email-mporter@ti.com> Message-ID: <201301300932.58732.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 30 January 2013, Matt Porter wrote: > + dma_cap_set(DMA_SLAVE, edma_filter_info.dma_cap); > + of_dma_controller_register(dev->of_node, > + of_dma_simple_xlate, > + &edma_filter_info); > + } How do you actually deal with the problem mentioned by Padma, that the filter function does not know which edma instance it is looking at? If you assume that there can only be a single edma instance in the system, that is probably a limitation that should be documented somewhere, and ideally the probe() function should check for that. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229Ab3A3Jdi (ORCPT ); Wed, 30 Jan 2013 04:33:38 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:58158 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552Ab3A3Jde (ORCPT ); Wed, 30 Jan 2013 04:33:34 -0500 From: Arnd Bergmann To: Matt Porter Subject: Re: [PATCH v6 03/10] ARM: edma: add AM33XX support to the private EDMA API Date: Wed, 30 Jan 2013 09:32:58 +0000 User-Agent: KMail/1.12.2 (Linux/3.8.0-1-generic; KDE/4.3.2; x86_64; ; ) Cc: Tony Lindgren , Sekhar Nori , Grant Likely , Mark Brown , Benoit Cousson , Russell King , Vinod Koul , Rob Landley , Chris Ball , Devicetree Discuss , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux Documentation List , Linux MMC List , Linux SPI Devel List , Dan Williams , Rob Herring , Padma Venkat References: <1359529229-22207-1-git-send-email-mporter@ti.com> <1359529229-22207-4-git-send-email-mporter@ti.com> In-Reply-To: <1359529229-22207-4-git-send-email-mporter@ti.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201301300932.58732.arnd@arndb.de> X-Provags-ID: V02:K0:Hwa28OO2Dsss6knu5+4+3ZiFaW1pQr3bbAl61JwqUUM ec07xmDaftZhsrDFuZaFOR8MJu7mrHQxEpZAjsqMBLEb7RO7/g TITZuiXTYzf3X/BsGQFcA+ZVYkkk+aOuF4av6trcP1TvXidAtJ 3YNc44PjqsTn4Fso6yJPae0FWKQ6s/llpKqC4ZCyIBnZm3ze1Z KKm/MLv72gPr5TMZKt1m9NCooQakzv1Xpzgw3pm2b+wQg/3tEu 0f6TrIugoO58Wp7JGqwL+DU6Wztx8LK3o0IjOdiMB91HTkygGu NiczXQidtqTAJ2w/HiZTVu3CVHuRb0wIC1ewOUcznQ3+ZmCmtb +L7Hy5Bhk9eo9JXi3cWg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 30 January 2013, Matt Porter wrote: > + dma_cap_set(DMA_SLAVE, edma_filter_info.dma_cap); > + of_dma_controller_register(dev->of_node, > + of_dma_simple_xlate, > + &edma_filter_info); > + } How do you actually deal with the problem mentioned by Padma, that the filter function does not know which edma instance it is looking at? If you assume that there can only be a single edma instance in the system, that is probably a limitation that should be documented somewhere, and ideally the probe() function should check for that. Arnd