Re: [meta-oe][[RFC][PATCH] nodejs: add 0.8.18

["Eric Bénard" <eric@eukrea.com>]

Hi Koen,

Le Wed, 30 Jan 2013 09:02:35 +0100,
Koen Kooi <koen@dominion.thruhere.net> a écrit :
> +++ b/meta-oe/recipes-devtools/nodejs/nodejs/0002-Enable-NEON.patch
> @@ -0,0 +1,27 @@
> +From 8891cb4cae57a6b7db54edb33a43743c4b09c53a Mon Sep 17 00:00:00 2001
> +From: Jason Kridner <jdk@ti.com>
> +Date: Wed, 7 Nov 2012 14:43:55 -0500
> +Subject: [PATCH] Enable NEON
> +
> +Read this was necessary on a blog.
> +
> +http://www.code-with-passion.com/2012/11/07/cross-compiling-nodejs-and-node-modules-for-armbeaglebone/
> +---
> + deps/v8/build/common.gypi |    1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/deps/v8/build/common.gypi b/deps/v8/build/common.gypi
> +index 7a780cc..237f53f 100644
> +--- a/deps/v8/build/common.gypi
> ++++ b/deps/v8/build/common.gypi
> +@@ -29,6 +29,7 @@
> + 
> + {
> +   'variables': {
> ++    'arm_neon%': 1,
> +     'use_system_v8%': 0,
> +     'msvs_use_common_release': 0,
> +     'gcc_version%': 'unknown',
> +-- 

How will that behave on CPU without neon (armv5 for example) ?
Did you test it on qemu for example ?

Eric