From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH] vfs: set s_type in alloc_super()
Date: Wed, 30 Jan 2013 15:08:26 +0000 [thread overview]
Message-ID: <20130130150826.GL4503@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1359504971-20153-1-git-send-email-jlayton@redhat.com>
On Tue, Jan 29, 2013 at 07:16:11PM -0500, Jeff Layton wrote:
> I see no reason to wait until after the "set" operation returns to set
> the s_type. We do call destroy_super() in some cases with that value
> unset. That seems to be OK in almost all cases, but we had a fire-drill
> recently with some RHEL-only patches that oopsed because the s_type was
> unset when destroy_super() got called.
>
> Move the setting of the s_type into alloc_super() as a defensive coding
> measure.
NAK. If anything, I'm seriously tempted to zero ->s_type in
deactivate_locked_super() just before we do put_filesystem_type() and
that reference becomes garbage.
prev parent reply other threads:[~2013-01-30 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 0:16 [PATCH] vfs: set s_type in alloc_super() Jeff Layton
2013-01-30 15:08 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130150826.GL4503@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.