All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/10] usb: mxs: Disable USB Port 1 for i.MX23
Date: Wed, 30 Jan 2013 15:17:39 +0100	[thread overview]
Message-ID: <201301301517.39470.marex@denx.de> (raw)
In-Reply-To: <1359548001-14278-8-git-send-email-otavio@ossystems.com.br>

Dear Otavio Salvador,

> The i.MX23 just one USB port so disable the second controller probe
> when building for i.MX23.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  drivers/usb/host/ehci-mxs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/host/ehci-mxs.c b/drivers/usb/host/ehci-mxs.c
> index 5062af5..28c8cde 100644
> --- a/drivers/usb/host/ehci-mxs.c
> +++ b/drivers/usb/host/ehci-mxs.c
> @@ -50,10 +50,12 @@ int mxs_ehci_get_port(struct ehci_mxs *mxs_usb, int
> port) usb_base = MXS_USBCTRL0_BASE;
>  		phy_base = MXS_USBPHY0_BASE;
>  		break;
> +#ifdef CONFIG_MX28
>  	case 1:
>  		usb_base = MXS_USBCTRL1_BASE;
>  		phy_base = MXS_USBPHY1_BASE;
>  		break;
> +#endif
>  	default:
>  		printf("CONFIG_EHCI_MXS_PORT (port = %d)\n", port);
>  		return -1;

This is not enough.

For example this portion will do something undefined on mx23:

 98         writel(HW_DIGCTL_CTRL_USB0_CLKGATE | HW_DIGCTL_CTRL_USB1_CLKGATE,
 99                 &digctl_ctrl->reg_clr);

THis ehci-mxs.c needs full review for mx23.

Best regards,
Marek Vasut

  reply	other threads:[~2013-01-30 14:17 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 12:13 [U-Boot] [PATCH 0/10] mx23/mxs pending patches Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 01/10] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT Otavio Salvador
2013-01-30 14:11   ` Marek Vasut
2013-01-30 15:29     ` Otavio Salvador
2013-02-01 23:42       ` Simon Glass
2013-01-30 12:13 ` [U-Boot] [PATCH 02/10] mx23: Document the tRAS lockout setting in memory initialization Otavio Salvador
2013-01-30 14:10   ` Marek Vasut
2013-01-30 15:23     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 03/10] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
2013-01-30 14:12   ` Marek Vasut
2013-01-30 15:34     ` Otavio Salvador
2013-01-30 15:38       ` Marek Vasut
2013-01-30 15:46         ` Otavio Salvador
2013-01-30 15:55           ` Marek Vasut
2013-01-30 16:00             ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 04/10] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 05/10] mxs: Fix iomux.h to not break build during assembly stage Otavio Salvador
2013-01-30 12:24   ` Fabio Estevam
2013-01-30 12:28     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 06/10] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-01-30 14:13   ` Marek Vasut
2013-01-30 15:34     ` Otavio Salvador
2013-01-30 15:39       ` Marek Vasut
2013-01-30 15:50         ` Otavio Salvador
2013-01-30 16:05           ` Marek Vasut
2013-01-30 16:08             ` Otavio Salvador
2013-01-30 16:15               ` Marek Vasut
2013-01-30 17:02                 ` Otavio Salvador
2013-01-30 18:14                   ` Marek Vasut
2013-01-30 12:13 ` [U-Boot] [PATCH 07/10] usb: mxs: Disable USB Port 1 for i.MX23 Otavio Salvador
2013-01-30 14:17   ` Marek Vasut [this message]
2013-01-30 15:36     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 08/10] mx23evk: Enable USB support Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 09/10] mx23_olinuxino: " Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 10/10] mx23_olinuxino: Add ethernet support Otavio Salvador
2013-01-30 14:18   ` Marek Vasut
2013-01-30 15:38     ` Otavio Salvador
2013-01-30 15:40       ` Marek Vasut
2013-01-30 15:51         ` Otavio Salvador
2013-01-30 16:06           ` Marek Vasut
2013-01-30 16:09             ` Otavio Salvador
2013-01-30 16:16               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301301517.39470.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.