From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Baltieri Subject: Re: [PATCH v7 1/4] cpufreq: handle SW coordinated CPUs Date: Wed, 30 Jan 2013 17:57:39 +0100 Message-ID: <20130130165739.GA21329@balto.lan> References: <1359550803-18577-1-git-send-email-fabio.baltieri@linaro.org> <1359550803-18577-2-git-send-email-fabio.baltieri@linaro.org> <20130130162225.GB30559@balto.lan> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar Cc: "Rafael J. Wysocki" , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, Linus Walleij , swarren@wwwdotorg.org, linaro-dev@lists.linaro.org, Nicolas Pitre , mathieu.poirier@linaro.org, Joseph Lo , linux-kernel@vger.kernel.org, Rickard Andersson On Wed, Jan 30, 2013 at 10:21:03PM +0530, Viresh Kumar wrote: > > I'm not sure about the name through, I like mentioning sw coordination in it > > because that's the comment in the declaration: > > > > cpumask_var_t cpus; /* CPUs requiring sw coordination */ > > cpumask_var_t related_cpus; /* CPUs with any coordination */ > > > > And those two are already confusing as a starting point. > > I will fix these comments with a patch of mine. Great! > > > Anyway, this sounds fine to me. If you think this is useful I can send > > a patch, or feel free to include it in your patches if you plan to do > > further cleanup work on this code. > > > > /me tries to also keep that ->cpu field in mind. > > You can make it part of your patchsets v8. I'm not sending a v8 as Rafael already asked for incremental, but I'll send a patch with that soon. Thanks, Fabio -- Fabio Baltieri