From: gmbnomis@gmail.com (Simon Baatz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kirkwood: of_serial: fix clock gating by removing clock-frequency
Date: Wed, 30 Jan 2013 21:50:36 +0100 [thread overview]
Message-ID: <20130130205035.GA20203@schnuecks.de> (raw)
In-Reply-To: <1359493774-27627-1-git-send-email-jason@lakedaemon.net>
Hi Jason,
On Tue, Jan 29, 2013 at 09:09:34PM +0000, Jason Cooper wrote:
> When DT support for kirkwood was first introduced, there was no clock
> infrastructure. As a result, we had to manually pass the
> clock-frequency to the driver from the device node.
>
> Unfortunately, on kirkwood, with minimal config or all module configs,
> clock-frequency breaks booting because of_serial doesn't consume the
> gate_clk when clock-frequency is defined.
>
> The end result on kirkwood is that runit gets gated, and then the boot
> fails when the kernel tries to write to the serial port.
>
> Fix the issue by removing the clock-frequency parameter from all
> kirkwood dts files.
>
> Booted on dreamplug without earlyprintk and successfully logged in via
> ttyS0.
>
> Reported-by: Simon Baatz <gmbnomis@gmail.com>
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> ---
If you like, you can add my
Tested-by: Simon Baatz <gmbnomis@gmail.com>
(On IB-NAS6210 serial console, earlyprintk and successful login via
ttyS0)
- Simon
next prev parent reply other threads:[~2013-01-30 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 21:09 [PATCH] ARM: kirkwood: of_serial: fix clock gating by removing clock-frequency Jason Cooper
2013-01-30 20:50 ` Simon Baatz [this message]
2013-02-04 1:33 ` Jason Cooper
2013-02-05 10:54 ` Simon Guinot
2013-02-05 11:13 ` Jason Cooper
2013-02-14 20:38 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130205035.GA20203@schnuecks.de \
--to=gmbnomis@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.