All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: fix CONFIG_DELAY_ENVIRONMENT to act like it claims in the README
Date: Wed, 30 Jan 2013 15:04:53 -0800	[thread overview]
Message-ID: <20130130230452.GB18391@badger> (raw)
In-Reply-To: <CAPnjgZ27WRS3qN25vk6RvSXrfCFaBR=B+uzG_gnyH=v51aUX3w@mail.gmail.com>

On Tue, Jan 22, 2013 at 06:12:47AM -0800, Simon Glass wrote:
> On Tue, Jan 22, 2013 at 2:15 AM, Lucas Stach <dev@lynxeye.de> wrote:
> > No one expects to end up in a delayed environment if
> > CONFIG_DELAY_ENVIRONMENT isn't defined.
> >
> > Signed-off-by: Lucas Stach <dev@lynxeye.de>
> 
> Good with me, and solves the immediate problem. Thanks for doing the patch.
> 
> Acked-by: Simon Glass <sjg@chromium.org>
> 

Adding Tom Rini and Albert.  What's the best way to get this up to
u-boot/master as quickly as possible?  Environment is broken on all
boards that use fdt until this goes in.

-Allen

> > ---
> > v2: keep preference of CONFIG_OF_CONTROL and just change default value
> > ---
> >  arch/arm/lib/board.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> > index cfe32cc..9f861cc 100644
> > --- a/arch/arm/lib/board.c
> > +++ b/arch/arm/lib/board.c
> > @@ -488,7 +488,7 @@ static char *failed = "*** failed ***\n";
> >  static int should_load_env(void)
> >  {
> >  #ifdef CONFIG_OF_CONTROL
> > -       return fdtdec_get_config_int(gd->fdt_blob, "load-environment", 0);
> > +       return fdtdec_get_config_int(gd->fdt_blob, "load-environment", 1);
> >  #elif defined CONFIG_DELAY_ENVIRONMENT
> >         return 0;
> >  #else
> > --
> > 1.8.0.2
> >
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

-- 
nvpublic

  reply	other threads:[~2013-01-30 23:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 10:15 [U-Boot] [PATCH v2] arm: fix CONFIG_DELAY_ENVIRONMENT to act like it claims in the README Lucas Stach
2013-01-22 14:12 ` Simon Glass
2013-01-30 23:04   ` Allen Martin [this message]
2013-01-31  0:31     ` Tom Rini
2013-01-31  0:34       ` Allen Martin
2013-01-30 18:25 ` Allen Martin
2013-01-31  0:33 ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130130230452.GB18391@badger \
    --to=amartin@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.