All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Millenbach <jmillenbach@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alan Cox <alan@linux.intel.com>, Jiri Slaby <jirislaby@gmail.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Josh Triplett <josh@joshtriplett.org>,
	Jamey Sharp <jamey@minilop.net>
Subject: Re: [PATCHv5] tty: Added a CONFIG_TTY option to allow removal of TTY
Date: Thu, 31 Jan 2013 06:17:28 +0100	[thread overview]
Message-ID: <20130131051728.GA2961@kroah.com> (raw)
In-Reply-To: <1359594919-2819-1-git-send-email-jmillenbach@gmail.com>

On Wed, Jan 30, 2013 at 05:15:19PM -0800, Joe Millenbach wrote:
> The option allows you to remove TTY and compile without errors. This
> saves space on systems that won't support TTY interfaces anyway.
> bloat-o-meter output is below.
> 
> The bulk of this patch consists of Kconfig changes adding "depends on
> TTY" to various serial devices and similar drivers that require the TTY
> layer.  Ideally, these dependencies would occur on a common intermediate
> symbol, but many drivers select rather than depend on features, and
> "select" does not respect dependencies.
> 
> bloat-o-meter output filtered to not show removed entries to save space
> 
> $ scripts/bloat-o-meter min min-no-tty | awk '$3 != "-"'
> add/remove: 0/225 grow/shrink: 2/12 up/down: 8/-29628 (-29620)
> function                                     old     new   delta
> chr_dev_init                                 138     145      +7
> linux_banner                                 123     124      +1
> static.__warned                              132     131      -1
> unregister_console                           106     101      -5
> start_kernel                                 467     462      -5
> register_console                             545     540      -5
> copy_from_user                                40      35      -5
> sys_setsid                                   105      98      -7
> sys_vhangup                                   27      15     -12
> do_exit                                     1363    1346     -17
> arch_local_irq_save                          136     116     -20
> bitmap_zero                                   44      22     -22
> release_task                                 587     562     -25
> static.spin_unlock_irqrestore                223     187     -36
> 
> Signed-off-by: Joe Millenbach <jmillenbach@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Reviewed-by: Jamey Sharp <jamey@minilop.net>
> ---
> v5: Rebasing to 3.8 rc5 and minimized driver/input changes based on input
>     from Dmitry Torokhov.

This isn't going to work because I've already applied this to my tree.
Can you just make a tiny patch against the tty-next git tree to fix up
the differences here for the Input drivers and I can apply that?

thanks,

greg k-h

  reply	other threads:[~2013-01-31  5:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31  1:15 [PATCHv5] tty: Added a CONFIG_TTY option to allow removal of TTY Joe Millenbach
2013-01-31  5:17 ` Greg Kroah-Hartman [this message]
2013-01-31 17:35   ` Joe Millenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130131051728.GA2961@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alan@linux.intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jamey@minilop.net \
    --cc=jirislaby@gmail.com \
    --cc=jmillenbach@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.