Re: [RFC PATCH 1/1] omap: xload: switch to generic bootstrap - Jean-Christophe PLAGNIOL-VILLARD

From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH 1/1] omap: xload: switch to generic bootstrap
Date: Thu, 31 Jan 2013 14:20:45 +0100	[thread overview]
Message-ID: <20130131132045.GC26329@game.jcrosoft.org> (raw)
In-Reply-To: <20130130221314.GA11480@pengutronix.de>

On 23:13 Wed 30 Jan     , Sascha Hauer wrote:
> On Mon, Jan 21, 2013 at 03:38:01PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > Hi,
> > 
> > 	just compiled not tested
> 
> Just tested on panda, this does not work.
> 
> > +static __noreturn int omap_xload(void)
> > +{
> > +	int (*func)(void) = NULL;
> > +
> > +	switch (omap_bootsrc())
> > +	{
> 
> { should be in the previous line.
> 
> > +	case OMAP_BOOTSRC_MMC1:
> > +		printf("booting from MMC1\n");
> > +		func = bootstrap_read_disk("disk0.0", NULL);
> 
> For some reason the autodetection does not work, with "fat" it works. I
> haven't investigated why. Anything else but fat does not make sense
> anyway since the OMAP ROM code expects a FAT for the MLO here and barebox
> is on the same partition.
> 
> > +		break;
> > +	case OMAP_BOOTSRC_USB1:
> > +		if (IS_ENABLED(CONFIG_FS_OMAP4_USBBOOT)) {
> > +			printf("booting from USB1\n");
> > +			func = bootstrap_read_disk("omap4_usbboot", "omap4_usbbootfs");
> 
> 'func' is set but not used now.
it's 

	bootstrap_boot(func, false);

ligne 57

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox