From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stratos Karafotis <stratosk@semaphore.gr>
Cc: Anton Vorontsov <anton.vorontsov@linaro.org>,
Oleg Nesterov <oleg@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
David Rientjes <rientjes@google.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: android: Restructure code in lowmemorykiller
Date: Thu, 31 Jan 2013 23:25:11 +0100 [thread overview]
Message-ID: <20130131222511.GA21654@kroah.com> (raw)
In-Reply-To: <510AE2D6.6010101@semaphore.gr>
On Thu, Jan 31, 2013 at 11:32:06PM +0200, Stratos Karafotis wrote:
> This patch restructures code for better readability and easier
> maintenance.
Given that no one is working on it, why does it need to be maintained
easier? :)
> Also introduces lowmemorykiller.h header file.
Why create a .h file? Who needs it? Only create a .h file if some
other .c file needs something in it, never for just one .c file.
sorry,
greg k-h
next prev parent reply other threads:[~2013-01-31 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 21:32 [PATCH] drivers: android: Restructure code in lowmemorykiller Stratos Karafotis
2013-01-31 22:25 ` Greg Kroah-Hartman [this message]
2013-01-31 22:48 ` Stratos Karafotis
2013-02-01 6:48 ` Dan Carpenter
2013-02-01 7:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131222511.GA21654@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=stratosk@semaphore.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.