All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: mingo@redhat.com, peterz@infradead.org, paulus@samba.org,
	acme@ghostprotocols.net, penberg@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] liblock: public headers for mutex implementation
Date: Fri, 1 Feb 2013 10:57:01 +0100	[thread overview]
Message-ID: <20130201095701.GA23061@gmail.com> (raw)
In-Reply-To: <1359694058-24452-3-git-send-email-sasha.levin@oracle.com>


* Sasha Levin <sasha.levin@oracle.com> wrote:

> These headers provide the same API as their pthread mutex counterparts.
> 
> The design here is to allow to easily switch to liblock lock validation
> just by adding a "liblock_" to pthread_mutex_*() calls, which means that
> it's easy to integrate liblock into existing codebases.

I'd suggest to name the user-space counterpart 'liblockdep', to 
make it clear that this is user-space lockdep.

Regarding pthread_mutex_t checking, I think what we *really* 
want is a wrapper that can be activated via:

#define __USE_LIBLOCKDEP

And which then takes over the pthread primitives via:

  #define pthread_mutex_lock liblockdep_pthread_mutex_lock

or so.

That way the source code only needs a __USE_LIBLOCKDEP in one or 
two key places and checking is activated.

Thanks,

	Ingo

  reply	other threads:[~2013-02-01  9:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01  4:47 [PATCH 0/7] liblock: userspace lockdep Sasha Levin
2013-02-01  4:47 ` [PATCH 1/7] liblock: wrap kernel/lockdep.c to allow usage from userspace Sasha Levin
2013-02-01  4:47 ` [PATCH 2/7] liblock: public headers for mutex implementation Sasha Levin
2013-02-01  9:57   ` Ingo Molnar [this message]
2013-02-01 14:20     ` Sasha Levin
2013-02-01  4:47 ` [PATCH 3/7] liblock: mutex test suite Sasha Levin
2013-02-01  4:47 ` [PATCH 4/7] liblock: public headers for rwlock implementation Sasha Levin
2013-02-01  4:47 ` [PATCH 5/7] liblock: rwlock test suite Sasha Levin
2013-02-01  4:47 ` [PATCH 6/7] liblock: add a MAINTAINERS entry Sasha Levin
2013-02-01  4:47 ` [PATCH 7/7] perf: integrate liblock support into perf Sasha Levin
2013-02-01  7:35 ` [PATCH 0/7] liblock: userspace lockdep Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130201095701.GA23061@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.