From: Joerg Roedel <joro@8bytes.org>
To: Shuah Khan <shuah.khan@hp.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
iommu@lists.linux-foundation.org, shuahkhan@gmail.com
Subject: Re: IO_PAGE_FAULTs on unity mapped regions during amd_iommu_init() in Linux 3.4
Date: Fri, 1 Feb 2013 14:00:35 +0100 [thread overview]
Message-ID: <20130201130035.GE25591@8bytes.org> (raw)
In-Reply-To: <1359657210.6061.3.camel@lorien2>
Hi Shuah,
On Thu, Jan 31, 2013 at 11:33:30AM -0700, Shuah Khan wrote:
> Access to these ranges continues to work with no errors until AMD IOMMU
> driver disables and re-enables IOMMU in enable_iommus(). These faults
> don't persist and appear between the enable_iommus() call and before
> amd_iommu_init() gets done printing "AMD-Vi: Lazy IO/TLB flushing
> enabled" message.
Hmm, okay. I had a look into the v3.4 sources. This looks like a race
condition. The IOMMUs are enabled in amd_iommu_init_hardware() but the
unity-mapped regions are created later in amd_iommu_init_dma_ops(). This
leaves a small window where the page-faults happen that you see.
But I am not sure why this doesn't hit on 3.7 and above. The race is
still there. Anyway, definitly something that needs to be fixed.
Joerg
next prev parent reply other threads:[~2013-02-01 13:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 18:33 IO_PAGE_FAULTs on unity mapped regions during amd_iommu_init() in Linux 3.4 Shuah Khan
2013-02-01 13:00 ` Joerg Roedel [this message]
2013-02-01 18:31 ` Shuah Khan
2013-02-05 13:31 ` Joerg Roedel
2013-02-05 13:31 ` Joerg Roedel
[not found] ` <20130205133104.GC2532-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-02-05 13:57 ` Shuah Khan
2013-02-05 13:57 ` Shuah Khan
2013-02-06 12:12 ` Joerg Roedel
2013-02-07 2:40 ` Shuah Khan
2013-02-11 19:49 ` Greg KH
2013-02-11 19:49 ` Greg KH
[not found] ` <20130211194901.GA18115-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-02-11 20:17 ` Shuah Khan
2013-02-11 20:17 ` Shuah Khan
2013-02-11 20:57 ` Shuah Khan
2013-02-11 22:18 ` Joerg Roedel
2013-02-11 22:18 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201130035.GE25591@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah.khan@hp.com \
--cc=shuahkhan@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.