From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org,
Stanislav Kinsbursky <skinsbursky@parallels.com>
Subject: Re: [PATCH v1 08/16] nfsd: break out hashtable search into separate function
Date: Fri, 1 Feb 2013 10:51:31 -0500 [thread overview]
Message-ID: <20130201155131.GA6508@fieldses.org> (raw)
In-Reply-To: <20130201102640.6b1898cb@tlielax.poochiereds.net>
On Fri, Feb 01, 2013 at 10:26:40AM -0500, Jeff Layton wrote:
> On Fri, 1 Feb 2013 08:14:09 -0500
> "J. Bruce Fields" <bfields@fieldses.org> wrote:
>
> > On Mon, Jan 28, 2013 at 02:41:14PM -0500, Jeff Layton wrote:
> > > Later, we'll need more than one call site for this, so break it out
> > > into a new function.
> >
> > I'm applying these first 8 to the for-3.9 branch at:
> >
> > git://linux-nfs.org/~bfields/linux.git for-3.9
> >
> > --b.
> >
>
> Thanks Bruce. I rebased the remaining patches on top of these, and now
> I'm seeing this when I try to test against it. I don't think it's due
> to the DRC patches, but I haven't started tracking it down yet:
Probably Stanislav's latest patches to the cache upcall code. I'm
surprised I didn't hit it.
--b.
>
> [10607.327785] BUG: unable to handle kernel NULL pointer dereference at (null)
> [10607.328033] IP: [<ffffffffa0164f95>] qword_add+0x5/0xd0 [sunrpc]
> [10607.328033] PGD 0
> [10607.328033] Oops: 0000 [#1] SMP
> [10607.328033] Modules linked in: nfsd(OF) auth_rpcgss nfs_acl lockd sunrpc kvm_amd kvm microcode virtio_balloon virtio_net i2c_piix4 cirrus drm_kms_helper ttm drm virtio_blk i2c_core
> [10607.328033] CPU 0
> [10607.328033] Pid: 5209, comm: nfsd Tainted: GF O 3.8.0-0.rc5.git2.1.fc19.x86_64 #1 Bochs Bochs
> [10607.328033] RIP: 0010:[<ffffffffa0164f95>] [<ffffffffa0164f95>] qword_add+0x5/0xd0 [sunrpc]
> [10607.328033] RSP: 0018:ffff88000307db58 EFLAGS: 00010286
> [10607.328033] RAX: ffff8800644e3a08 RBX: 000000000a5a51ab RCX: 0000000000000000
> [10607.328033] RDX: ffff88004367ee70 RSI: 0000000000000000 RDI: 000000000a5a51ab
> [10607.328033] RBP: ffff88000307db80 R08: 0000000000000000 R09: 0000000000000000
> [10607.328033] R10: ffff8800436c0000 R11: 0000000000000000 R12: ffff8800644bf730
> [10607.328033] R13: 0000000000000000 R14: ffff88000307db98 R15: ffff880002f5dd40
> [10607.328033] FS: 00007fb85bea8740(0000) GS:ffff88007fc00000(0000) knlGS:0000000000000000
> [10607.328033] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [10607.328033] CR2: 0000000000000000 CR3: 00000000030ba000 CR4: 00000000000006f0
> [10607.328033] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [10607.328033] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [10607.328033] Process nfsd (pid: 5209, threadinfo ffff88000307c000, task ffff8800436c0000)
> [10607.328033] Stack:
> [10607.328033] ffffffffa01b56de ffff88000307db78 ffff8800644bf730 00000000fffffff5
> [10607.328033] ffff880005e409d8 ffff88000307dbd0 ffffffffa0166ee7 0000000000000078
> [10607.328033] 00000000510bb440 000000000a5a51ab ffff880005e43138 ffff8800644e3a08
> [10607.328033] Call Trace:
> [10607.328033] [<ffffffffa01b56de>] ? expkey_request+0x2e/0x90 [nfsd]
> [10607.328033] [<ffffffffa0166ee7>] cache_check+0xe7/0x350 [sunrpc]
> [10607.328033] [<ffffffffa01b613e>] exp_find+0x17e/0x350 [nfsd]
> [10607.328033] [<ffffffffa01b5fc5>] ? exp_find+0x5/0x350 [nfsd]
> [10607.328033] [<ffffffffa01b76d5>] ? rqst_exp_find+0x5/0x300 [nfsd]
> [10607.328033] [<ffffffffa01b77ee>] rqst_exp_find+0x11e/0x300 [nfsd]
> [10607.328033] [<ffffffffa01b76d5>] ? rqst_exp_find+0x5/0x300 [nfsd]
> [10607.328033] [<ffffffffa01b7a82>] rqst_find_fsidzero_export+0x22/0x30 [nfsd]
> [10607.328033] [<ffffffffa01b7aaa>] exp_pseudoroot+0x1a/0xb0 [nfsd]
> [10607.328033] [<ffffffffa01bf565>] nfsd4_putrootfh+0x25/0x30 [nfsd]
> [10607.328033] [<ffffffffa01c00f3>] nfsd4_proc_compound+0x573/0x790 [nfsd]
> [10607.328033] [<ffffffffa01abedb>] nfsd_dispatch+0xbb/0x200 [nfsd]
> [10607.328033] [<ffffffffa015aadd>] svc_process_common+0x46d/0x6e0 [sunrpc]
> [10607.328033] [<ffffffffa015ae57>] svc_process+0x107/0x170 [sunrpc]
> [10607.328033] [<ffffffffa01ab28f>] nfsd+0xbf/0x130 [nfsd]
> [10607.328033] [<ffffffffa01ab1d0>] ? nfsd_destroy+0x220/0x220 [nfsd]
> [10607.328033] [<ffffffff81090cea>] kthread+0xea/0xf0
> [10607.328033] [<ffffffff81090c00>] ? insert_kthread_work+0x80/0x80
> [10607.328033] [<ffffffff816e086c>] ret_from_fork+0x7c/0xb0
> [10607.328033] [<ffffffff81090c00>] ? insert_kthread_work+0x80/0x80
> [10607.328033] Code: 4c c3 81 e8 9e cd f6 e0 85 c0 0f 85 0d fe ff ff e9 5a ff ff ff 0f 0b 0f 0b 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 66 66 66 66 90 <8b> 0e 55 4c 8b 07 48 89 e5 85 c9 78 56 66 0f 1f 44 00 00 48 83
> [10607.328033] RIP [<ffffffffa0164f95>] qword_add+0x5/0xd0 [sunrpc]
> [10607.328033] RSP <ffff88000307db58>
> [10607.328033] CR2: 0000000000000000
> [10607.961841] ---[ end trace b5a4adf462b23e9a ]---
>
> Does it look familiar at all?
>
> --
> Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2013-02-01 15:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 19:41 [PATCH v1 00/16] nfsd: duplicate reply cache overhaul Jeff Layton
2013-01-28 19:41 ` [PATCH v1 01/16] nfsd: fix IPv6 address handling in the DRC Jeff Layton
2013-01-28 19:51 ` Chuck Lever
2013-01-28 20:05 ` Jeff Layton
2013-01-28 20:16 ` Chuck Lever
2013-01-28 20:26 ` Jeff Layton
2013-01-28 20:34 ` Chuck Lever
2013-01-28 20:45 ` Jeff Layton
2013-01-28 20:54 ` Chuck Lever
2013-01-28 21:06 ` Jeff Layton
2013-01-28 21:32 ` Chuck Lever
2013-01-29 13:33 ` Jeff Layton
2013-01-31 20:59 ` J. Bruce Fields
2013-01-31 21:06 ` Jeff Layton
2013-01-28 19:41 ` [PATCH v1 02/16] nfsd: remove unneeded spinlock in nfsd_cache_update Jeff Layton
2013-01-31 21:23 ` J. Bruce Fields
2013-01-28 19:41 ` [PATCH v1 03/16] nfsd: get rid of RC_INTR Jeff Layton
2013-01-28 19:41 ` [PATCH v1 04/16] nfsd: create a dedicated slabcache for DRC entries Jeff Layton
2013-01-28 19:41 ` [PATCH v1 05/16] nfsd: add alloc and free functions " Jeff Layton
2013-01-28 19:41 ` [PATCH v1 06/16] nfsd: remove redundant test from nfsd_reply_cache_free Jeff Layton
2013-01-28 19:41 ` [PATCH v1 07/16] nfsd: clean up and clarify the cache expiration code Jeff Layton
2013-01-28 19:41 ` [PATCH v1 08/16] nfsd: break out hashtable search into separate function Jeff Layton
2013-02-01 13:14 ` J. Bruce Fields
2013-02-01 15:26 ` Jeff Layton
2013-02-01 15:48 ` Jeff Layton
2013-02-01 15:51 ` J. Bruce Fields [this message]
2013-02-01 16:01 ` Jeff Layton
2013-02-01 16:05 ` J. Bruce Fields
2013-01-28 19:41 ` [PATCH v1 09/16] nfsd: always move DRC entries to the end of LRU list when updating timestamp Jeff Layton
2013-01-28 19:41 ` [PATCH v1 10/16] nfsd: dynamically allocate DRC entries Jeff Layton
2013-01-30 15:16 ` J. Bruce Fields
2013-01-30 15:20 ` Jeff Layton
2013-01-28 19:41 ` [PATCH v1 11/16] nfsd: remove the cache_disabled flag Jeff Layton
2013-01-28 19:41 ` [PATCH v1 12/16] nfsd: when updating an entry with RC_NOCACHE, just free it Jeff Layton
2013-01-28 19:41 ` [PATCH v1 13/16] nfsd: add recurring workqueue job to clean the cache Jeff Layton
2013-01-28 19:41 ` [PATCH v1 14/16] nfsd: track the number of DRC entries in " Jeff Layton
2013-01-28 19:41 ` [PATCH v1 15/16] nfsd: register a shrinker for DRC cache entries Jeff Layton
2013-01-30 15:24 ` J. Bruce Fields
2013-01-30 15:37 ` Jeff Layton
2013-01-28 19:41 ` [PATCH v1 16/16] nfsd: keep a checksum of the first 256 bytes of request Jeff Layton
2013-01-29 18:20 ` Jeff Layton
2013-01-30 15:14 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201155131.GA6508@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=skinsbursky@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.