From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
John Keeping <john@keeping.me.uk>,
git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Max Horn <max@quendi.de>
Subject: Re: [PATCH 1/2] Documentation/Makefile: clean up MAN*_TXT lists
Date: Fri, 1 Feb 2013 11:20:10 -0800 [thread overview]
Message-ID: <20130201192010.GA12368@google.com> (raw)
In-Reply-To: <20130201082650.GA25783@sigill.intra.peff.net>
Jeff King wrote:
> We keep a list of the various files that end up as man1,
> man5, etc. Let's break these single-line lists into sorted
> multi-line lists, which makes diffs that touch them much
> easier to read.
Independentally of the rest of the series, I think this is a good
cleanup.
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -1,13 +1,28 @@ MAN7_TXT += gitcredentials.txt
> -MAN1_TXT= \
> - $(filter-out $(addsuffix .txt, $(ARTICLES) $(SP_ARTICLES)), \
> - $(wildcard git-*.txt)) \
> - gitk.txt gitweb.txt git.txt
> +MAN1_TXT += git.txt
> +MAN1_TXT += gitk.txt
> +MAN1_TXT += gitweb.txt
> +
If the user happens to have MAN[157]_TXT set in the environment, this
would be affected by that. How about:
# Guard against environment variables
MAN1_TXT =
MAN5_TXT =
MAN7_TXT =
MAN1_TXT += ...
...
?
With that change,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2013-02-01 19:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 20:11 git-remote-helpers.txt: should it be gitremote-helpers.txt? John Keeping
2013-01-30 20:28 ` Junio C Hamano
2013-01-31 20:08 ` [PATCH] gitremote-helpers.txt: rename from git-remote-helpers.txt John Keeping
2013-01-31 20:18 ` Matthieu Moy
2013-01-31 20:36 ` Junio C Hamano
2013-01-31 21:59 ` [PATCH] Rename {git- => git}remote-helpers.txt John Keeping
2013-01-31 22:13 ` Junio C Hamano
2013-01-31 22:28 ` John Keeping
2013-01-31 22:43 ` Junio C Hamano
2013-01-31 22:56 ` John Keeping
2013-01-31 23:49 ` Junio C Hamano
2013-01-31 22:33 ` Jeff King
2013-01-31 22:48 ` Junio C Hamano
2013-01-31 23:04 ` Jonathan Nieder
2013-01-31 23:11 ` Junio C Hamano
2013-01-31 23:13 ` Jonathan Nieder
2013-02-01 5:03 ` Jeff King
2013-02-01 5:37 ` Junio C Hamano
2013-02-01 7:33 ` Jeff King
2013-02-01 8:25 ` Jeff King
2013-02-01 8:26 ` [PATCH 1/2] Documentation/Makefile: clean up MAN*_TXT lists Jeff King
2013-02-01 19:20 ` Jonathan Nieder [this message]
2013-02-01 19:38 ` Junio C Hamano
2013-02-01 19:38 ` Jeff King
2013-02-01 19:41 ` Jeff King
2013-02-01 8:27 ` [PATCH 2/2] docs: convert "concept" manpages to git-* Jeff King
2013-02-01 19:25 ` Jonathan Nieder
2013-02-01 18:52 ` [PATCH] Rename {git- => git}remote-helpers.txt Junio C Hamano
2013-02-01 19:00 ` Jeff King
2013-02-01 22:15 ` Junio C Hamano
2013-01-31 22:28 ` [PATCH] gitremote-helpers.txt: rename from git-remote-helpers.txt Tomas Carnecky
2013-01-31 22:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201192010.GA12368@google.com \
--to=jrnieder@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=max@quendi.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.