From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 1 Feb 2013 14:05:10 -0800 From: Tony Lindgren To: Philip Avinash Subject: Re: [PATCH 1/4] arch: arm: gpmc: gpmc migration support Message-ID: <20130201220510.GY22517@atomide.com> References: <1358933176-12409-1-git-send-email-avinashphilip@ti.com> <1358933176-12409-2-git-send-email-avinashphilip@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358933176-12409-2-git-send-email-avinashphilip@ti.com> Cc: khilman@ti.com, afzal@ti.com, linux@arm.linux.org.uk, nsekhar@ti.com, linux-kernel@vger.kernel.org, gururaja.hebbar@ti.com, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Philip Avinash [130123 01:28]: > With recent GPMC driver conversion, usage of gpmc_save/restore_context > can done from gpmc driver itself. Hence removes the usage from pm34xx.c. > Also removes the conditional compilation primitives ARCH_OMAP3 for > gpmc_save/restore_context. Hmm I think this will break GPMC for deeper idle modes. Note that we need to save and restore the context every time hitting off-idle, not just for suspend and resume. Or am I missing something here? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/4] arch: arm: gpmc: gpmc migration support Date: Fri, 1 Feb 2013 14:05:10 -0800 Message-ID: <20130201220510.GY22517@atomide.com> References: <1358933176-12409-1-git-send-email-avinashphilip@ti.com> <1358933176-12409-2-git-send-email-avinashphilip@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:47472 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757791Ab3BAWFS (ORCPT ); Fri, 1 Feb 2013 17:05:18 -0500 Content-Disposition: inline In-Reply-To: <1358933176-12409-2-git-send-email-avinashphilip@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Philip Avinash Cc: khilman@ti.com, linux@arm.linux.org.uk, dwmw2@infradead.org, afzal@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, nsekhar@ti.com, gururaja.hebbar@ti.com * Philip Avinash [130123 01:28]: > With recent GPMC driver conversion, usage of gpmc_save/restore_context > can done from gpmc driver itself. Hence removes the usage from pm34xx.c. > Also removes the conditional compilation primitives ARCH_OMAP3 for > gpmc_save/restore_context. Hmm I think this will break GPMC for deeper idle modes. Note that we need to save and restore the context every time hitting off-idle, not just for suspend and resume. Or am I missing something here? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 1 Feb 2013 14:05:10 -0800 Subject: [PATCH 1/4] arch: arm: gpmc: gpmc migration support In-Reply-To: <1358933176-12409-2-git-send-email-avinashphilip@ti.com> References: <1358933176-12409-1-git-send-email-avinashphilip@ti.com> <1358933176-12409-2-git-send-email-avinashphilip@ti.com> Message-ID: <20130201220510.GY22517@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Philip Avinash [130123 01:28]: > With recent GPMC driver conversion, usage of gpmc_save/restore_context > can done from gpmc driver itself. Hence removes the usage from pm34xx.c. > Also removes the conditional compilation primitives ARCH_OMAP3 for > gpmc_save/restore_context. Hmm I think this will break GPMC for deeper idle modes. Note that we need to save and restore the context every time hitting off-idle, not just for suspend and resume. Or am I missing something here? Regards, Tony