From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] ARM: Fix malloc area size for versatile and integrator
Date: Sun, 3 Feb 2013 00:40:00 +0100 [thread overview]
Message-ID: <201302030040.00408.marex@denx.de> (raw)
In-Reply-To: <20130203003505.5cd321d3@lilith>
Dear Albert ARIBAUD,
> Hi Marek,
>
> On Sat, 3 Nov 2012 10:11:27 +0100, Marek Vasut <marex@denx.de> wrote:
> > These boards couldn't save their environment because they couldn't
> > malloc() the whole size of the sector.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > ---
> >
> > include/configs/integrator-common.h | 3 ++-
> > include/configs/versatile.h | 2 +-
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > V2: Align with current code
> >
> > diff --git a/include/configs/integrator-common.h
> > b/include/configs/integrator-common.h index 564b418..51227e7 100644
> > --- a/include/configs/integrator-common.h
> > +++ b/include/configs/integrator-common.h
> > @@ -37,7 +37,8 @@
> >
> > #define
> > CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> > #define CONFIG_SYS_MAXARGS 16 /* max number of command args */
#define
> > CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument
Buffer Size*/
> >
> > -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128*1024) /*
Size of
> > malloc() pool */ +/* Size of malloc() pool */
> > +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE +
128*1024)
> >
> > #define CONFIG_CMDLINE_TAG /* enable passing of ATAGs */
> > #define CONFIG_SETUP_MEMORY_TAGS
> >
> > diff --git a/include/configs/versatile.h b/include/configs/versatile.h
> > index a65c676..2484881 100644
> > --- a/include/configs/versatile.h
> > +++ b/include/configs/versatile.h
> > @@ -71,7 +71,7 @@
> >
> > * Size of malloc() pool
> > */
> >
> > #define CONFIG_ENV_SIZE 8192
> >
> > -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128 * 1024)
> > +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128 *
1024)
> >
> > /*
> >
> > * Hardware drivers
>
> This does not build properly on current ARM ToT:
>
> board.c:395:19: error: 'CONFIG_ENV_SECT_SIZE' undeclared (first use in
> this function)
>
> All 4 of integratorap_cm720t integratorap_cm920t integratorap_cm926ejs
> integratorap_cm946es fail.
Yea well, the original patch is like one year old now ... I guess these things
happen.
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-02-02 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-17 2:41 [U-Boot] [PATCH] ARM: Fix malloc area size for versatile and integrator Marek Vasut
2012-03-18 23:34 ` Linus Walleij
2012-03-18 23:37 ` Marek Vasut
2012-11-03 9:11 ` [U-Boot] [PATCH V2] " Marek Vasut
2013-02-02 23:35 ` Albert ARIBAUD
2013-02-02 23:40 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302030040.00408.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.