From: Ingo Molnar <mingo@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
akpm@linux-foundation.org, acme@redhat.com, eranian@google.com,
jolsa@redhat.com, namhyung@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 04/12] perf, x86: Support the TSX intx/intx_cp qualifiers v3
Date: Sun, 3 Feb 2013 11:52:21 +0100 [thread overview]
Message-ID: <20130203105221.GE9330@gmail.com> (raw)
In-Reply-To: <20130201150302.GN30577@one.firstfloor.org>
* Andi Kleen <andi@firstfloor.org> wrote:
> > As requested before, please keep those in a completely
> > separate series so that minimal support can be merged
> > upstream. This is
>
> Hi Ingo, The goal is not to merge "minimal support" but full
> support.
Stop these idiotic excuses and stop the obstruction already!
Firstly, it is long standing kernel maintenance policy to first
go for supporting existing applications, ABIs, binaries.
The bulks of your other changes need changes to the ABI and
changes to tools - and won't be made use of by any of the
existing installed base of profiling tooling.
It is entirely reasonable and in fact required of me to separate
out and handle those in a second wave of changes, and this is
the fourth time you hinder Haswell support by not addressing
maintainer feedback.
Every other perf contributor understands those concepts.
Secondly, as it's being demonstrated in this discussion again,
you are a historically problematic contributor who often
produces avoidably crappy code that needs several iterations to
get right. You also have a track record of not willing to
improve and you have a track record of being needlessly
argumentative and disruptive. All in one, I currently cannot
trust your code and refuse to handle long, complex patch series
from you.
Thanks,
Ingo
next prev parent reply other threads:[~2013-02-03 10:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 22:51 Basic perf PMU support for Haswell v2 Andi Kleen
2013-01-31 22:51 ` [PATCH 01/12] perf, x86: Add PEBSv2 record support Andi Kleen
2013-02-01 17:18 ` Stephane Eranian
2013-01-31 22:51 ` [PATCH 02/12] perf, x86: Basic Haswell PMU support v3 Andi Kleen
2013-02-01 17:22 ` Stephane Eranian
2013-01-31 22:51 ` [PATCH 03/12] perf, x86: Basic Haswell PEBS support v4 Andi Kleen
2013-02-01 17:26 ` Stephane Eranian
2013-01-31 22:51 ` [PATCH 04/12] perf, x86: Support the TSX intx/intx_cp qualifiers v3 Andi Kleen
2013-02-01 10:16 ` Ingo Molnar
2013-02-01 15:03 ` Andi Kleen
2013-02-03 10:52 ` Ingo Molnar [this message]
2013-01-31 22:51 ` [PATCH 05/12] perf, x86: Support Haswell v4 LBR format Andi Kleen
2013-01-31 22:51 ` [PATCH 06/12] perf, x86: Support full width counting Andi Kleen
2013-01-31 22:51 ` [PATCH 07/12] perf, x86: Avoid checkpointed counters causing excessive TSX aborts v4 Andi Kleen
2013-01-31 22:51 ` [PATCH 08/12] perf, x86: Move NMI clearing to end of PMI handler after the counter registers are reset Andi Kleen
2013-01-31 22:51 ` [PATCH 09/12] perf, x86: Disable LBR recording for unknown LBR_FMT Andi Kleen
2013-01-31 22:51 ` [PATCH 10/12] perf, x86: Support LBR filtering by INTX/NOTX/ABORT v3 Andi Kleen
2013-01-31 22:51 ` [PATCH 11/12] perf, tools: Support sorting by intx, abort branch flags v2 Andi Kleen
2013-01-31 22:51 ` [PATCH 12/12] perf, tools: Add abort_tx,no_tx,in_tx branch filter options to perf record -j v3 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203105221.GE9330@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.