From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools: set migration constraints from cmdline
Date: Mon, 4 Feb 2013 10:57:10 +0100 [thread overview]
Message-ID: <20130204095709.GB2564@aepfle.de> (raw)
In-Reply-To: <1359556230.12252.235.camel@zakaz.uk.xensource.com>
On Wed, Jan 30, Ian Campbell wrote:
> On Mon, 2013-01-28 at 17:32 +0000, Olaf Hering wrote:
> > A variant of this change has been tested with xend, the patch below is
> > only compile tested. The changes to libxl change the API, is that
> > approach acceptable?
>
> I'm afraid not, the compatibility requirements are covered in the
> comment near the top of libxl.h.
>
> So you either need a new function or to leverage the LIBXL_API_VERSION
> define (which the user must supply) such that people providing 0x040200
> see the current interface and people providing 0x040300 (or nothing) see
> the new one.
And to avoid the API change at all, should max_iters and max_factor be
passed via xenstore to xc_domain_save()? So that either the caller of
xc_domain_save reads the values from xenstore, or the function itself
reads it from there. What do you think?
Olaf
next prev parent reply other threads:[~2013-02-04 9:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 17:32 [PATCH] tools: set migration constraints from cmdline Olaf Hering
2013-01-30 14:30 ` Ian Campbell
2013-01-30 16:43 ` Olaf Hering
2013-02-04 9:57 ` Olaf Hering [this message]
2013-02-04 12:54 ` Ian Campbell
2013-02-04 13:09 ` Olaf Hering
2013-02-04 13:14 ` Ian Campbell
2013-01-30 16:41 ` [PATCH v2] " Olaf Hering
2013-01-31 16:17 ` [PATCH v3] " Olaf Hering
2013-02-01 19:34 ` [PATCH v4] " Olaf Hering
2013-02-04 13:11 ` Ian Campbell
2013-02-04 13:41 ` Olaf Hering
2013-02-04 13:46 ` Ian Campbell
2013-02-04 13:55 ` Olaf Hering
2013-02-04 13:59 ` Ian Campbell
2013-02-04 18:43 ` Olaf Hering
2013-02-05 9:22 ` Ian Campbell
2013-02-05 10:16 ` Olaf Hering
2013-02-19 11:42 ` Olaf Hering
2013-02-19 11:48 ` Ian Campbell
2013-02-19 14:12 ` Olaf Hering
2013-02-05 10:03 ` [PATCH v5] " Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204095709.GB2564@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.