From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools: set migration constraints from
	cmdline
Date: Mon, 4 Feb 2013 10:57:10 +0100
Message-ID: <20130204095709.GB2564@aepfle.de>
References: <577b051fca174be9f7b3.1359394360@probook.site>
	<1359556230.12252.235.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1359556230.12252.235.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, Jan 30, Ian Campbell wrote:

> On Mon, 2013-01-28 at 17:32 +0000, Olaf Hering wrote:
> > A variant of this change has been tested with xend, the patch below is
> > only compile tested. The changes to libxl change the API, is that
> > approach acceptable?
> 
> I'm afraid not, the compatibility requirements are covered in the
> comment near the top of libxl.h.
> 
> So you either need a new function or to leverage the LIBXL_API_VERSION
> define (which the user must supply) such that people providing 0x040200
> see the current interface and people providing 0x040300 (or nothing) see
> the new one.

And to avoid the API change at all, should max_iters and max_factor be
passed via xenstore to xc_domain_save()? So that either the caller of
xc_domain_save reads the values from xenstore, or the function itself
reads it from there. What do you think?


Olaf