From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] tools/xc: restore logging in xc_save Date: Mon, 4 Feb 2013 11:50:07 +0100 Message-ID: <20130204105007.GA10728@aepfle.de> References: <1359972720.5281.20.camel@zakaz.uk.xensource.com> <20130204102331.GA6328@aepfle.de> <1359974276.5281.40.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1359974276.5281.40.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Mon, Feb 04, Ian Campbell wrote: > On Mon, 2013-02-04 at 10:23 +0000, Olaf Hering wrote: > > On Mon, Feb 04, Ian Campbell wrote: > > > > > On Fri, 2013-02-01 at 18:58 +0000, Olaf Hering wrote: > > > > + lvl = si.flags & XCFLAGS_DEBUG ? XTL_DEBUG: XTL_DETAIL; > > > > + lflags = XTL_STDIOSTREAM_HIDE_PROGRESS; > > > > > > Would it be useful (as an extension) to implement an XTL_STDIOSTREAM > > > flag which makes it output something more suitable for logging, > > > e.g. ...10%...20%...30%... > > > (or perhaps automatic based on isatty(outputfd)?) > > > > I was thinking about that, to extend the called progress functions. In > > the case of xend.log it would produce many lines of progress. > > How come many lines? I imaged the above as a single line. Oh, I did not realize that we did not talk about XTL_STDIOSTREAM_HIDE_PROGRESS but about another new flag. > > No idea if any caller makes use of the progress, given that it did not > > work at all without the other patch I sent last Friday. > > xl migrate uses AFAIK, which isn't to say it wasn't broken ;-) For me it was not printed without the patch in <6d1d516ecaade56f796e.1359738924@probook.site> > Although I did mean to ask why the code had to move? To get to si.flags. Olaf