Re: [PATCH v4] tools: set migration constraints from cmdline

[Olaf Hering <olaf@aepfle.de>]

On Mon, Feb 04, Ian Campbell wrote:

> > Instead the migration should be aborted and the guest should continue to
> > run on the old host.
> 
> That's what I understood from reading the code, can we make the docs say
> it too ;-)

-A --abort-if-busy maybe?

> > > >  =item B<remus> [I<OPTIONS>] I<domain-id> I<host>
> > > > diff -r fd711ebdce9a -r 785c8f34e1f8 tools/libxc/xc_domain_save.c
> > > > --- a/tools/libxc/xc_domain_save.c
> > > > +++ b/tools/libxc/xc_domain_save.c
> > > 
> > > The changes to this file only seem to implement the -N and not the other
> > > two?
> > 
> > xc_domain_save already has max_iters and max_factor as arguments.
> 
> Ah, I didn't appreciate that.
> 
> BTW did you want to add a way to override DEF_MIN_REMAINING?

I did consider it, but havent looked closer how to do it.

> I'm not really sure what the usecase is for save -c. I'd be a bit
> inclined to leave it until someone wants it I think.

save -c looks like a snapshot feature, but does not seem to take storage
into accound. So yes, I will leave it alone.

Olaf