From: "J. Bruce Fields" <bfields@fieldses.org>
To: Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: linux-nfs@vger.kernel.org, Trond.Myklebust@netapp.com,
linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root
Date: Mon, 4 Feb 2013 09:17:19 -0500 [thread overview]
Message-ID: <20130204141719.GA815@fieldses.org> (raw)
In-Reply-To: <20130204105728.11633.53621.stgit@localhost.localdomain>
On Mon, Feb 04, 2013 at 02:02:29PM +0300, Stanislav Kinsbursky wrote:
> swapping
>
> The main idea of this patch set is to call cache request not on kthread
> upcall, but on userspace daemon cache_read call. This fixes the problem with
> gaining of wrong dentry path after calling d_path() in kthread root context
> (svc_export_request() callback), which always work in init root context, but
> containers can work in "root jail" - i.e. have it's own nested root.
>
> v2:
> 1) NFS DNS cache update wasn't done in the firest version. So this patch set
> does preparation cleanup of the NFS DNS cache routines.
> 2) Also, this patch set doesn't remove cache_upcall helper anymore, because
> it's still required for NFS DNS cache.
Argh--I really prefer incremental patches once I've already committed
something, but OK.
Backing out the old patches, I'll take a look at these. The first two
should probably get an ACK from Trond.
--b.
>
> The following series implements...
>
> ---
>
> Stanislav Kinsbursky (6):
> NFS: use SUNRPC cache creation and destruction helper for DNS cache
> NFS; simlify and clean cache library
> SUNRPC: introduce cache_detail->cache_request callback
> SUNRPC: rework cache upcall logic
> SUNRPC: remove "cache_request" argument in sunrpc_cache_pipe_upcall() function
> SUNRPC: move cache_detail->cache_request callback call to cache_read()
>
>
> fs/nfs/cache_lib.c | 12 ++-----
> fs/nfs/cache_lib.h | 2 -
> fs/nfs/dns_resolve.c | 65 +++++++++++++++----------------------
> fs/nfsd/export.c | 14 +-------
> fs/nfsd/nfs4idmap.c | 16 +--------
> include/linux/sunrpc/cache.h | 10 +++---
> net/sunrpc/auth_gss/svcauth_gss.c | 8 +----
> net/sunrpc/cache.c | 49 ++++++++++++++++------------
> net/sunrpc/svcauth_unix.c | 14 +-------
> 9 files changed, 69 insertions(+), 121 deletions(-)
>
next prev parent reply other threads:[~2013-02-04 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 11:02 [PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root Stanislav Kinsbursky
2013-02-04 11:02 ` [PATCH v2 1/6] NFS: use SUNRPC cache creation and destruction helper for DNS cache Stanislav Kinsbursky
2013-02-08 21:13 ` J. Bruce Fields
2013-02-04 11:02 ` [PATCH v2 2/6] NFS; simlify and clean cache library Stanislav Kinsbursky
2013-02-08 21:14 ` J. Bruce Fields
2013-02-04 11:02 ` [PATCH v2 3/6] SUNRPC: introduce cache_detail->cache_request callback Stanislav Kinsbursky
2013-02-04 11:02 ` [PATCH v2 4/6] SUNRPC: rework cache upcall logic Stanislav Kinsbursky
2013-02-04 11:02 ` [PATCH v2 5/6] SUNRPC: remove "cache_request" argument in sunrpc_cache_pipe_upcall() function Stanislav Kinsbursky
2013-02-04 11:03 ` [PATCH v2 6/6] SUNRPC: move cache_detail->cache_request callback call to cache_read() Stanislav Kinsbursky
2013-02-04 14:17 ` J. Bruce Fields [this message]
2013-02-05 5:36 ` [PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204141719.GA815@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=skinsbursky@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.