From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chris Rattray <crattray@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: wm2200: Provide platform data for MICBIAS configuration
Date: Mon, 4 Feb 2013 18:25:01 +0000 [thread overview]
Message-ID: <20130204182501.GP4720@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1360001403-2183-1-git-send-email-crattray@opensource.wolfsonmicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 544 bytes --]
On Mon, Feb 04, 2013 at 06:10:03PM +0000, Chris Rattray wrote:
> +enum wm2200_mbias_lvl {
> + WM2200_MBIAS_LVL_1V5 = 0,
> + WM2200_MBIAS_LVL_1V8 = 1,
> + WM2200_MBIAS_LVL_1V9 = 2,
> + WM2200_MBIAS_LVL_2V0 = 3,
> + WM2200_MBIAS_LVL_2V2 = 4,
> + WM2200_MBIAS_LVL_2V4 = 5,
> + WM2200_MBIAS_LVL_2V5 = 6,
> + WM2200_MBIAS_LVL_2V6 = 7,
> +};
It would be better to specify this in terms of milivolts; this means
that if the user does not specify anything then we'll use the chip
default which should be sane and is generally the expected behaviour.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-02-04 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 18:10 [PATCH] ASoC: wm2200: Provide platform data for MICBIAS configuration Chris Rattray
2013-02-04 18:25 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-05 14:40 Chris Rattray
2013-02-05 15:53 ` Mark Brown
2013-02-05 16:26 Chris Rattray
2013-02-05 16:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204182501.GP4720@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=crattray@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.